[builtins] Move StringIncludes to a builtin.

[builtins] Move StringIncludes to a builtin.

Also add a test for when the first argument is null or undefined, as there are no tests that cover this currently.

BUG=v8:5364
Committed: https://crrev.com/8b48aa1cda024150ecbc8509ebdc40e399eddb0e
Cr-Commit-Position: refs/heads/master@{#40127}

[petermarshall, 2016-10-07 21:16:36]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 21:16:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 21:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 21:51:24]

Dry run: This issue passed the CQ dry run.

[petermarshall, 2016-10-07 22:00:23]

petermarshall@chromium.org changed reviewers:
+ bmeurer@chromium.org, franzih@chromium.org

[petermarshall, 2016-10-07 22:00:23]

PTAL

[Benedikt Meurer, 2016-10-09 18:10:09]

lgtm

[Franzi, 2016-10-10 07:27:06]

On 2016/10/09 at 18:10:09, bmeurer wrote:
> lgtm

lgtm

[petermarshall, 2016-10-10 07:53:10]

The CQ bit was checked by petermarshall@chromium.org

[petermarshall, 2016-10-10 07:53:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, franzih@chromium.org
Link to the patchset: https://codereview.chromium.org/2399423003/#ps60001
(title: "Change incorrect variable name")

[commit-bot: I haz the power, 2016-10-10 07:53:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 08:31:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-10 08:31:50]

Description was changed from

==========
[builtins] Move StringIncludes to a builtin.

BUG=v8:5364
==========

to

==========
[builtins] Move StringIncludes to a builtin.

BUG=v8:5364

Committed: https://crrev.com/b374d719e79a5b32168c25c0cda30056f5e6e36c
Cr-Commit-Position: refs/heads/master@{#40110}
==========

[commit-bot: I haz the power, 2016-10-10 08:31:51]

Patchset 4 (id:??) landed as
https://crrev.com/b374d719e79a5b32168c25c0cda30056f5e6e36c
Cr-Commit-Position: refs/heads/master@{#40110}

[petermarshall, 2016-10-10 11:22:57]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2407793002/ by petermarshall@chromium.org.

The reason for reverting is: String.includes crashes when called with null or
undefined as the first param.

[petermarshall, 2016-10-10 12:06:00]

Description was changed from

==========
[builtins] Move StringIncludes to a builtin.

BUG=v8:5364

Committed: https://crrev.com/b374d719e79a5b32168c25c0cda30056f5e6e36c
Cr-Commit-Position: refs/heads/master@{#40110}
==========

to

==========
[builtins] Move StringIncludes to a builtin.

Also add a test for when the first argument is null or undefined, as there are
no tests that cover this currently.

BUG=v8:5364
==========

[petermarshall, 2016-10-10 12:07:19]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 12:07:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 12:30:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 12:30:40]

Dry run: This issue passed the CQ dry run.

[petermarshall, 2016-10-10 12:33:21]

PTAL, fixed bug where GetProperty was called on null or undefined and added
tests.

[Franzi, 2016-10-10 12:58:00]

On 2016/10/10 at 12:33:21, petermarshall wrote:
> PTAL, fixed bug where GetProperty was called on null or undefined and added
tests.

LGTM

[Franzi, 2016-10-10 12:58:59]

https://codereview.chromium.org/2399423003/diff/100001/test/mjsunit/es6/strin...
File test/mjsunit/es6/string-includes.js (right):

https://codereview.chromium.org/2399423003/diff/100001/test/mjsunit/es6/strin...
test/mjsunit/es6/string-includes.js:33: 
Can we add assertFalse(s.includes()); just to prevent mistakes in the future?

[petermarshall, 2016-10-10 14:34:35]

The CQ bit was checked by petermarshall@chromium.org

[petermarshall, 2016-10-10 14:34:36]

PTAL one last time, I added the extra test case s.includes() (no params) and I
moved the IsRegExp helper to Object and used that instead of re-implementing it
inside the builtin.

[petermarshall, 2016-10-10 14:34:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, franzih@chromium.org
Link to the patchset: https://codereview.chromium.org/2399423003/#ps120001
(title: "Add another test. Re-use IsRegExp logic")

[commit-bot: I haz the power, 2016-10-10 14:34:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 15:01:25]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-10 15:01:36]

Description was changed from

==========
[builtins] Move StringIncludes to a builtin.

Also add a test for when the first argument is null or undefined, as there are
no tests that cover this currently.

BUG=v8:5364
==========

to

==========
[builtins] Move StringIncludes to a builtin.

Also add a test for when the first argument is null or undefined, as there are
no tests that cover this currently.

BUG=v8:5364

Committed: https://crrev.com/8b48aa1cda024150ecbc8509ebdc40e399eddb0e
Cr-Commit-Position: refs/heads/master@{#40127}
==========

[commit-bot: I haz the power, 2016-10-10 15:01:37]

Patchset 7 (id:??) landed as
https://crrev.com/8b48aa1cda024150ecbc8509ebdc40e399eddb0e
Cr-Commit-Position: refs/heads/master@{#40127}