src/builtins/builtins.h - Issue 2399423003: [builtins] Move StringIncludes to a builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins.h

Issue 2399423003: [builtins] Move StringIncludes to a builtin. (Closed)

Patch Set: Add another test. Re-use IsRegExp logic Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins.h

diff --git a/src/builtins/builtins.h b/src/builtins/builtins.h

index d5dd651523144cf3ae5a8b1134049bffdd79a259..f4b900b2219ef1b0dbbe4ef80c1b5b55d6e89680 100644

--- a/src/builtins/builtins.h

+++ b/src/builtins/builtins.h

@@ -604,6 +604,9 @@ namespace internal {

TFJ(StringPrototypeCharAt, 2) \

/* ES6 section 21.1.3.2 String.prototype.charCodeAt ( pos ) */ \

TFJ(StringPrototypeCharCodeAt, 2) \

+ /* ES6 section 21.1.3.7 */ \

+ /* String.prototype.includes ( searchString [ , position ] ) */ \

+ CPP(StringPrototypeIncludes) \

/* ES6 section 21.1.3.8 */ \

/* String.prototype.indexOf ( searchString [ , position ] ) */ \

CPP(StringPrototypeIndexOf) \

« no previous file with comments | « src/bootstrapper.cc ('k') | src/builtins/builtins-regexp.cc » ('j') | no next file with comments »