Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/objects.h

Issue 2399423003: [builtins] Move StringIncludes to a builtin. (Closed)
Patch Set: Add another test. Re-use IsRegExp logic Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/js/string.js ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 1358 matching lines...) Expand 10 before | Expand all | Expand 10 after
1369 Handle<Object> receiver, Handle<JSReceiver> setter, Handle<Object> value, 1369 Handle<Object> receiver, Handle<JSReceiver> setter, Handle<Object> value,
1370 ShouldThrow should_throw); 1370 ShouldThrow should_throw);
1371 1371
1372 MUST_USE_RESULT static inline MaybeHandle<Object> GetElement( 1372 MUST_USE_RESULT static inline MaybeHandle<Object> GetElement(
1373 Isolate* isolate, Handle<Object> object, uint32_t index); 1373 Isolate* isolate, Handle<Object> object, uint32_t index);
1374 1374
1375 MUST_USE_RESULT static inline MaybeHandle<Object> SetElement( 1375 MUST_USE_RESULT static inline MaybeHandle<Object> SetElement(
1376 Isolate* isolate, Handle<Object> object, uint32_t index, 1376 Isolate* isolate, Handle<Object> object, uint32_t index,
1377 Handle<Object> value, LanguageMode language_mode); 1377 Handle<Object> value, LanguageMode language_mode);
1378 1378
1379 // ES#sec-isregexp IsRegExp ( argument )
1380 // Includes checking of the mach property as per section 7.2.8 IsRegExp.
1381 static Maybe<bool> IsRegExp(Isolate* isolate, Handle<Object> object);
1382
1379 // Returns the permanent hash code associated with this object. May return 1383 // Returns the permanent hash code associated with this object. May return
1380 // undefined if not yet created. 1384 // undefined if not yet created.
1381 Object* GetHash(); 1385 Object* GetHash();
1382 1386
1383 // Returns the permanent hash code associated with this object depending on 1387 // Returns the permanent hash code associated with this object depending on
1384 // the actual object type. May create and store a hash code if needed and none 1388 // the actual object type. May create and store a hash code if needed and none
1385 // exists. 1389 // exists.
1386 static Smi* GetOrCreateHash(Isolate* isolate, Handle<Object> object); 1390 static Smi* GetOrCreateHash(Isolate* isolate, Handle<Object> object);
1387 1391
1388 // Checks whether this object has the same value as the given one. This 1392 // Checks whether this object has the same value as the given one. This
(...skipping 10053 matching lines...) Expand 10 before | Expand all | Expand 10 after
11442 } 11446 }
11443 return value; 11447 return value;
11444 } 11448 }
11445 }; 11449 };
11446 11450
11447 11451
11448 } // NOLINT, false-positive due to second-order macros. 11452 } // NOLINT, false-positive due to second-order macros.
11449 } // NOLINT, false-positive due to second-order macros. 11453 } // NOLINT, false-positive due to second-order macros.
11450 11454
11451 #endif // V8_OBJECTS_H_ 11455 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/js/string.js ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698