Add gl tests to make sure when a buffer is unmapped, all access path generates an INVALID_OPERATION.

Add gl tests to make sure when a buffer is unmapped, all access path generates an INVALID_OPERATION.

BUG=429053
TEST=gl_tests
R=vmiura@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
Cr-Commit-Position: refs/heads/master@{#424238}

[Zhenyao Mo, 2016-10-06 20:44:41]

Description was changed from

==========
Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.

BUG=429053
TEST=gl_tests
R=vmiura@chromium.org
==========

to

==========
Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.

BUG=429053
TEST=gl_tests
R=vmiura@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-06 20:53:02]

Description was changed from

==========
Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.

BUG=429053
TEST=gl_tests
R=vmiura@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.

BUG=429053
TEST=gl_tests
R=vmiura@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-06 20:53:07]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 20:53:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 21:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 21:40:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Zhenyao Mo, 2016-10-07 21:02:14]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-10-07 21:02:28]

vmiura: PTAL

[commit-bot: I haz the power, 2016-10-07 21:03:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-07 21:04:42]

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc (left):

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc:1491:
TEST_P(GLES3DecoderTest, TransformFeedbackStates) {
Moving this to webgl2 conformance tests because setting up a program and
transformfeedback varyings is a lot of code and it no longer serves as a unit
test.

[Zhenyao Mo, 2016-10-07 21:05:36]

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/program_manager.cc (right):

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.cc:697:
effective_transform_feedback_varyings_ = transform_feedback_varyings_;
This behavior will also be tested in the webgl2 conformance test suite.

[commit-bot: I haz the power, 2016-10-07 21:56:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 21:56:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmiura, 2016-10-10 18:20:48]

LGTM % comments

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/program_manager.h (right):

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.h:563: GLenum
effective_transform_feedback_buffer_mode_;
Please initialize effective_transform_feedback_buffer_mode_ to GL_NONE.

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc (right):

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc:406: 
These look good.  Could you also add a TODO for CopyBufferSubData?

[Zhenyao Mo, 2016-10-10 18:56:41]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 18:56:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:00:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:00:43]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-10-10 21:01:22]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-10-10 21:01:23]

The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org
Link to the patchset: https://codereview.chromium.org/2399113003/#ps60001
(title: "fix")

[Zhenyao Mo, 2016-10-10 21:02:07]

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/program_manager.h (right):

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.h:563: GLenum
effective_transform_feedback_buffer_mode_;
On 2016/10/10 18:20:48, vmiura wrote:
> Please initialize effective_transform_feedback_buffer_mode_ to GL_NONE.

Done.

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc (right):

https://codereview.chromium.org/2399113003/diff/40001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc:406: 
On 2016/10/10 18:20:48, vmiura wrote:
> These look good.  Could you also add a TODO for CopyBufferSubData?

Done.

[commit-bot: I haz the power, 2016-10-10 21:02:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:10:08]

Description was changed from

==========
Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.

BUG=429053
TEST=gl_tests
R=vmiura@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.

BUG=429053
TEST=gl_tests
R=vmiura@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-10 21:10:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-10 21:12:49]

Description was changed from

==========
Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.

BUG=429053
TEST=gl_tests
R=vmiura@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add gl tests to make sure when a buffer is unmapped, all access path generates
an INVALID_OPERATION.

BUG=429053
TEST=gl_tests
R=vmiura@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
Cr-Commit-Position: refs/heads/master@{#424238}
==========

[commit-bot: I haz the power, 2016-10-10 21:12:50]

Patchset 4 (id:??) landed as
https://crrev.com/7e06f15b71f7194c3761bcd3e1677954e5a9cdc4
Cr-Commit-Position: refs/heads/master@{#424238}

[dgn, 2016-10-11 10:03:36]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2410023002/ by dgn@chromium.org.

The reason for reverting is: The new tests have been crashing since they landed.

BUG=654709.