Record UMA stats for subframes history navigations.

Record UMA stats for subframes history navigations.

This CL tracks how often subframe history navigations go to a different
URL than the default frame src URL, and how long the unique names are
in these cases when they include frame paths.  The latter is useful for
knowing whether a plan to truncate unique names would affect session
history behavior.

This should be reverted after sufficient data is collected.

BUG=626202
TEST=UMA stats reported when going back after navigating an unnamed
     child frame, particularly unnamed grandchildren of subframes
     with long names.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/e20a1c11a51eb321964caa3db2196805fe9744f7
Cr-Commit-Position: refs/heads/master@{#423397}

[Charlie Reis, 2016-10-05 19:25:13]

Description was changed from

==========
Record UMA stats for subframes history navigations.

This CL tracks how often subframe history navigations go to a different
URL than the default frame src URL, and how long the unique names are
in these cases when they include frame paths.  The latter is useful for
knowing whether a plan to truncate unique names would affect session
history behavior.

This should be reverted after sufficient data is colleted.

BUG=626202
TEST=UMA stats reported when going back after navigating an unnamed
     child frame, particularly unnamed grandchildren of subframes
     with long names.
==========

to

==========
Record UMA stats for subframes history navigations.

This CL tracks how often subframe history navigations go to a different
URL than the default frame src URL, and how long the unique names are
in these cases when they include frame paths.  The latter is useful for
knowing whether a plan to truncate unique names would affect session
history behavior.

This should be reverted after sufficient data is colleted.

BUG=626202
TEST=UMA stats reported when going back after navigating an unnamed
     child frame, particularly unnamed grandchildren of subframes
     with long names.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Charlie Reis, 2016-10-05 19:30:01]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:30:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-10-05 19:32:04]

creis@chromium.org changed reviewers:
+ dcheng@chromium.org

[Charlie Reis, 2016-10-05 19:32:04]

Daniel, can you take a look?  I think this covers the case we're concerned
about.  If the frame path is very long (for cases where we aren't just
navigating to the frame's default URL), then we might have trouble matching it
up once we start truncating unique names.

If that happens, we may need to parse the frame path for history items from disk
and truncate the individual items.

https://codereview.chromium.org/2398753002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigator_impl.cc (right):

https://codereview.chromium.org/2398753002/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigator_impl.cc:464: restoring_different_url);
I thought I'd include this while we're at it, since I often wonder how often
users actually navigate in subframes in practice (and come back).  There's a lot
of complexity dedicated to it, so it's nice to have justification for it.

[dcheng, 2016-10-05 19:51:08]

lgtm

[Charlie Reis, 2016-10-05 20:31:06]

creis@chromium.org changed reviewers:
+ isherman@chromium.org

[Charlie Reis, 2016-10-05 20:31:07]

Thanks.  isherman@, can you take a look at histograms.xml?

[commit-bot: I haz the power, 2016-10-05 21:13:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 21:13:14]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-10-05 21:37:18]

creis@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Charlie Reis, 2016-10-05 21:37:19]

[+asvitkine, in case you're available sooner for histograms.xml]

[Charlie Reis, 2016-10-05 22:32:47]

Description was changed from

==========
Record UMA stats for subframes history navigations.

This CL tracks how often subframe history navigations go to a different
URL than the default frame src URL, and how long the unique names are
in these cases when they include frame paths.  The latter is useful for
knowing whether a plan to truncate unique names would affect session
history behavior.

This should be reverted after sufficient data is colleted.

BUG=626202
TEST=UMA stats reported when going back after navigating an unnamed
     child frame, particularly unnamed grandchildren of subframes
     with long names.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Record UMA stats for subframes history navigations.

This CL tracks how often subframe history navigations go to a different
URL than the default frame src URL, and how long the unique names are
in these cases when they include frame paths.  The latter is useful for
knowing whether a plan to truncate unique names would affect session
history behavior.

This should be reverted after sufficient data is collected.

BUG=626202
TEST=UMA stats reported when going back after navigating an unnamed
     child frame, particularly unnamed grandchildren of subframes
     with long names.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Ilya Sherman, 2016-10-05 22:52:06]

Metrics LGTM % nits:

https://codereview.chromium.org/2398753002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2398753002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:55780: +    enum="BooleanSuccess">
Please provide a more specifically relevant enum for this histogram.

https://codereview.chromium.org/2398753002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:55793: +    that are restoring a
different URL than the frames default src URL during a
nit: s/frames/frame's

[Charlie Reis, 2016-10-05 23:12:44]

https://codereview.chromium.org/2398753002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2398753002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:55780: +    enum="BooleanSuccess">
On 2016/10/05 22:52:06, Ilya Sherman wrote:
> Please provide a more specifically relevant enum for this histogram.

Done.

https://codereview.chromium.org/2398753002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:55793: +    that are restoring a
different URL than the frames default src URL during a
On 2016/10/05 22:52:06, Ilya Sherman wrote:
> nit: s/frames/frame's

Done.

[Charlie Reis, 2016-10-05 23:12:51]

The CQ bit was checked by creis@chromium.org

[Charlie Reis, 2016-10-05 23:12:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2398753002/#ps20001
(title: "Fix nits")

[commit-bot: I haz the power, 2016-10-05 23:13:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 02:19:53]

Description was changed from

==========
Record UMA stats for subframes history navigations.

This CL tracks how often subframe history navigations go to a different
URL than the default frame src URL, and how long the unique names are
in these cases when they include frame paths.  The latter is useful for
knowing whether a plan to truncate unique names would affect session
history behavior.

This should be reverted after sufficient data is collected.

BUG=626202
TEST=UMA stats reported when going back after navigating an unnamed
     child frame, particularly unnamed grandchildren of subframes
     with long names.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Record UMA stats for subframes history navigations.

This CL tracks how often subframe history navigations go to a different
URL than the default frame src URL, and how long the unique names are
in these cases when they include frame paths.  The latter is useful for
knowing whether a plan to truncate unique names would affect session
history behavior.

This should be reverted after sufficient data is collected.

BUG=626202
TEST=UMA stats reported when going back after navigating an unnamed
     child frame, particularly unnamed grandchildren of subframes
     with long names.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-10-06 02:19:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 02:23:25]

Description was changed from

==========
Record UMA stats for subframes history navigations.

This CL tracks how often subframe history navigations go to a different
URL than the default frame src URL, and how long the unique names are
in these cases when they include frame paths.  The latter is useful for
knowing whether a plan to truncate unique names would affect session
history behavior.

This should be reverted after sufficient data is collected.

BUG=626202
TEST=UMA stats reported when going back after navigating an unnamed
     child frame, particularly unnamed grandchildren of subframes
     with long names.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Record UMA stats for subframes history navigations.

This CL tracks how often subframe history navigations go to a different
URL than the default frame src URL, and how long the unique names are
in these cases when they include frame paths.  The latter is useful for
knowing whether a plan to truncate unique names would affect session
history behavior.

This should be reverted after sufficient data is collected.

BUG=626202
TEST=UMA stats reported when going back after navigating an unnamed
     child frame, particularly unnamed grandchildren of subframes
     with long names.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/e20a1c11a51eb321964caa3db2196805fe9744f7
Cr-Commit-Position: refs/heads/master@{#423397}
==========

[commit-bot: I haz the power, 2016-10-06 02:23:27]

Patchset 2 (id:??) landed as
https://crrev.com/e20a1c11a51eb321964caa3db2196805fe9744f7
Cr-Commit-Position: refs/heads/master@{#423397}