Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: content/browser/frame_host/navigator.h

Issue 2398753002: Record UMA stats for subframes history navigations. (Closed)
Patch Set: Fix nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 61d9e1374f0675083767dca7281cc63b91e46326..8ff2d8bc0f8d8a37e6eb8c3f28bed90a77ef0e19 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -101,7 +101,10 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
// navigates it in the correct process. Returns false if the
// FrameNavigationEntry can't be found or the navigation fails. This is only
// used in OOPIF-enabled modes.
- virtual bool NavigateNewChildFrame(RenderFrameHostImpl* render_frame_host);
+ // TODO(creis): Remove |default_url| once we have collected UMA stats on the
+ // cases that we use a different URL from history than the frame's src.
+ virtual bool NavigateNewChildFrame(RenderFrameHostImpl* render_frame_host,
+ const GURL& default_url);
// Navigation requests -------------------------------------------------------
« no previous file with comments | « no previous file | content/browser/frame_host/navigator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698