Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 2398753002: Record UMA stats for subframes history navigations. (Closed)
Patch Set: Fix nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "content/browser/frame_host/navigator_delegate.h" 10 #include "content/browser/frame_host/navigator_delegate.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 virtual bool NavigateToPendingEntry(FrameTreeNode* frame_tree_node, 94 virtual bool NavigateToPendingEntry(FrameTreeNode* frame_tree_node,
95 const FrameNavigationEntry& frame_entry, 95 const FrameNavigationEntry& frame_entry,
96 ReloadType reload_type, 96 ReloadType reload_type,
97 bool is_same_document_history_load); 97 bool is_same_document_history_load);
98 98
99 // Called on a newly created subframe during a history navigation. The browser 99 // Called on a newly created subframe during a history navigation. The browser
100 // process looks up the corresponding FrameNavigationEntry for the new frame 100 // process looks up the corresponding FrameNavigationEntry for the new frame
101 // navigates it in the correct process. Returns false if the 101 // navigates it in the correct process. Returns false if the
102 // FrameNavigationEntry can't be found or the navigation fails. This is only 102 // FrameNavigationEntry can't be found or the navigation fails. This is only
103 // used in OOPIF-enabled modes. 103 // used in OOPIF-enabled modes.
104 virtual bool NavigateNewChildFrame(RenderFrameHostImpl* render_frame_host); 104 // TODO(creis): Remove |default_url| once we have collected UMA stats on the
105 // cases that we use a different URL from history than the frame's src.
106 virtual bool NavigateNewChildFrame(RenderFrameHostImpl* render_frame_host,
107 const GURL& default_url);
105 108
106 // Navigation requests ------------------------------------------------------- 109 // Navigation requests -------------------------------------------------------
107 110
108 virtual base::TimeTicks GetCurrentLoadStart(); 111 virtual base::TimeTicks GetCurrentLoadStart();
109 112
110 // The RenderFrameHostImpl has received a request to open a URL with the 113 // The RenderFrameHostImpl has received a request to open a URL with the
111 // specified |disposition|. 114 // specified |disposition|.
112 virtual void RequestOpenURL( 115 virtual void RequestOpenURL(
113 RenderFrameHostImpl* render_frame_host, 116 RenderFrameHostImpl* render_frame_host,
114 const GURL& url, 117 const GURL& url,
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 virtual void DiscardPendingEntryIfNeeded(NavigationHandleImpl* handle) {} 196 virtual void DiscardPendingEntryIfNeeded(NavigationHandleImpl* handle) {}
194 197
195 protected: 198 protected:
196 friend class base::RefCounted<Navigator>; 199 friend class base::RefCounted<Navigator>;
197 virtual ~Navigator() {} 200 virtual ~Navigator() {}
198 }; 201 };
199 202
200 } // namespace content 203 } // namespace content
201 204
202 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 205 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698