Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2398623003: Re-land Reformat comments in core/layout up until LayoutBox (Closed)

Created:
4 years, 2 months ago by eae
Modified:
4 years, 2 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land Reformat comments in core/layout up until LayoutBox This reverts commit 64f8e6ee53f1542634b9bb32cc84f2e24356fee3. BUG=563793 R=ikilpatrick@chromium.org NOTRY=true Committed: https://crrev.com/fe06ac8eac8940be169f918a7e5845e0a0e51c6a Cr-Commit-Position: refs/heads/master@{#423661}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address reviewer comments #

Patch Set 3 : Rebase w/HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2287 lines, -1684 lines) Patch
M third_party/WebKit/Source/core/layout/ClipRect.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ClipRectsCache.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.h View 12 chunks +87 lines, -73 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 13 chunks +59 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/layout/CounterNode.h View 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/CounterNode.cpp View 5 chunks +27 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.h View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 1 2 5 chunks +22 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FragmentainerIterator.h View 1 chunk +14 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp View 7 chunks +20 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FragmentationContext.h View 1 chunk +26 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/GeneratedChildren.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestCache.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestLocation.cpp View 2 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestRequest.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.h View 4 chunks +27 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 4 chunks +15 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestingTransformState.h View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityController.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp View 8 chunks +22 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBR.h View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 10 chunks +31 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 48 chunks +225 lines, -153 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 9 chunks +43 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 122 chunks +651 lines, -471 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 64 chunks +224 lines, -166 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 29 chunks +137 lines, -100 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 134 chunks +597 lines, -452 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
eae
4 years, 2 months ago (2016-10-05 16:14:38 UTC) #1
ikilpatrick
lgtm; feel free ignore the 'bad' reflow in this patch :) https://codereview.chromium.org/2398623003/diff/1/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right): ...
4 years, 2 months ago (2016-10-05 16:28:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398623003/20001
4 years, 2 months ago (2016-10-05 16:42:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/306011)
4 years, 2 months ago (2016-10-05 20:44:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398623003/20001
4 years, 2 months ago (2016-10-05 20:47:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/274596)
4 years, 2 months ago (2016-10-05 20:59:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398623003/40001
4 years, 2 months ago (2016-10-06 19:03:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398623003/40001
4 years, 2 months ago (2016-10-06 20:35:46 UTC) #20
eae
On 2016/10/06 20:35:46, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 2 months ago (2016-10-06 20:36:04 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 20:46:30 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 20:49:10 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe06ac8eac8940be169f918a7e5845e0a0e51c6a
Cr-Commit-Position: refs/heads/master@{#423661}

Powered by Google App Engine
This is Rietveld 408576698