Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2398453002: Rewrap comments to 80 columns in Source/platform/graphics/. (Closed)

Created:
4 years, 2 months ago by Peter Kasting
Modified:
4 years, 2 months ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, blink-layers+watch_chromium.org, ajuma+watch-canvas_chromium.org, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrap comments to 80 columns in Source/platform/graphics/. This also makes some minor modifications (rewrite for clarity, etc.). BUG=563793 TEST=none Committed: https://crrev.com/5502b5a19ee85fb3d150dd20ce386f1699d45c01 Cr-Commit-Position: refs/heads/master@{#423280}

Patch Set 1 #

Patch Set 2 : Resync #

Total comments: 8

Patch Set 3 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -340 lines) Patch
M third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h View 1 2 2 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp View 6 chunks +20 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.h View 3 chunks +27 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 5 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DImageBufferSurface.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 9 chunks +25 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 4 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Color.h View 3 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Color.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorSpace.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositingReasons.h View 5 chunks +17 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp View 1 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp View 4 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTestWoPlatform.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h View 1 2 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Gradient.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 7 chunks +25 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 2 7 chunks +19 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContextState.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 2 7 chunks +20 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 10 chunks +35 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 4 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 6 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h View 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageDecodingStore.h View 5 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h View 4 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp View 5 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageOrientation.h View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImagePattern.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/PaintInvalidationReason.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Path.h View 4 chunks +18 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Path.cpp View 6 chunks +22 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/StrokeData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Peter Kasting
4 years, 2 months ago (2016-10-04 22:57:33 UTC) #2
Stephen White
LGTM. Nits are at your discretion. https://codereview.chromium.org/2398453002/diff/20001/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h File third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h (right): https://codereview.chromium.org/2398453002/diff/20001/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h#newcode88 third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h:88: // Thread that ...
4 years, 2 months ago (2016-10-05 14:45:38 UTC) #11
Peter Kasting
https://codereview.chromium.org/2398453002/diff/20001/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h File third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h (right): https://codereview.chromium.org/2398453002/diff/20001/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h#newcode88 third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h:88: // Thread that m_image belongs to. Set to null ...
4 years, 2 months ago (2016-10-05 18:46:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398453002/40001
4 years, 2 months ago (2016-10-05 18:47:20 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-05 20:46:38 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 20:48:30 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5502b5a19ee85fb3d150dd20ce386f1699d45c01
Cr-Commit-Position: refs/heads/master@{#423280}

Powered by Google App Engine
This is Rietveld 408576698