Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2398253002: Convert fpdfformfill to use CPDFSDK_FormFillEnvironment (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Convert fpdfformfill to use CPDFSDK_FormFillEnvironment This CL converts to using CPDFSDK_FormFillEnvironment instead of CPDFSDK_Document internally. Committed: https://pdfium.googlesource.com/pdfium/+/f3fbe83a0f6c1dfb05722a6f0a4056c53548fb6e

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -63 lines) Patch
M fpdfsdk/cpdfsdk_document.h View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_document.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 11 chunks +58 lines, -48 lines 0 comments Download
M fpdfsdk/fsdk_baseform_embeddertest.cpp View 4 chunks +7 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-11 14:06:58 UTC) #2
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-11 16:20:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398253002/20001
4 years, 2 months ago (2016-10-11 19:54:55 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 20:08:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/f3fbe83a0f6c1dfb05722a6f0a4056c53548...

Powered by Google App Engine
This is Rietveld 408576698