Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2397933003: Convert CPDFSDK_ActionHandler to CPDFSDK_FormFillEnvironment (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Convert CPDFSDK_ActionHandler to CPDFSDK_FormFillEnvironment This CL replaces CPDFSDK_Document with CPDFSDK_FormFillEnvironment in CPDFSDK_ActionHandler. Committed: https://pdfium.googlesource.com/pdfium/+/19c198b7b80633e6030457d276df99aee3ca8ca4

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -186 lines) Patch
M fpdfsdk/cpdfsdk_document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.h View 2 chunks +40 lines, -32 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 23 chunks +159 lines, -143 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-06 20:49:45 UTC) #2
dsinclair
ping.
4 years, 2 months ago (2016-10-11 14:06:38 UTC) #3
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-11 16:18:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397933003/20001
4 years, 2 months ago (2016-10-11 19:40:05 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 19:51:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/19c198b7b80633e6030457d276df99aee3ca...

Powered by Google App Engine
This is Rietveld 408576698