Convert CPDFXFA_Document to use CPDFSDK_FormFillEnvironment

Convert CPDFXFA_Document to use CPDFSDK_FormFillEnvironment

This CL removes the use of CPDFSDK_Document from CPDFXFA_Document.

Committed: https://pdfium.googlesource.com/pdfium/+/655fccab2f80af3a0e160116f30796e2da77f919

[dsinclair, 2016-10-11 14:07:12]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-10-11 14:07:13]

PTAL.

[Tom Sepez, 2016-10-11 16:30:39]

lgtm

https://codereview.chromium.org/2396213002/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
File fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp (right):

https://codereview.chromium.org/2396213002/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp:1016: return
m_pDocument->GetFormFillEnv()->GetJSRuntime()->SetValueByName(
nit {}

https://codereview.chromium.org/2396213002/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp:1028:
!m_pDocument->GetFormFillEnv()->GetJSRuntime())
nit {}

https://codereview.chromium.org/2396213002/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
File fpdfsdk/fpdfxfa/cpdfxfa_document.h (right):

https://codereview.chromium.org/2396213002/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_document.h:90: // Must be destroy before
|m_pFormFillEnv|.
nit: destroyed

[dsinclair, 2016-10-11 20:14:29]

https://codereview.chromium.org/2396213002/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
File fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp (right):

https://codereview.chromium.org/2396213002/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp:1016: return
m_pDocument->GetFormFillEnv()->GetJSRuntime()->SetValueByName(
On 2016/10/11 16:30:38, Tom Sepez wrote:
> nit {}

Done.

https://codereview.chromium.org/2396213002/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp:1028:
!m_pDocument->GetFormFillEnv()->GetJSRuntime())
On 2016/10/11 16:30:38, Tom Sepez wrote:
> nit {}

Done.

https://codereview.chromium.org/2396213002/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
File fpdfsdk/fpdfxfa/cpdfxfa_document.h (right):

https://codereview.chromium.org/2396213002/diff/20001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_document.h:90: // Must be destroy before
|m_pFormFillEnv|.
On 2016/10/11 16:30:38, Tom Sepez wrote:
> nit: destroyed

Done.

[dsinclair, 2016-10-11 20:14:41]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-10-11 20:14:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2396213002/#ps40001
(title: "Review fixes")

[commit-bot: I haz the power, 2016-10-11 20:14:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 20:53:41]

Description was changed from

==========
Convert CPDFXFA_Document to use CPDFSDK_FormFillEnvironment

This CL removes the use of CPDFSDK_Document from CPDFXFA_Document.
==========

to

==========
Convert CPDFXFA_Document to use CPDFSDK_FormFillEnvironment

This CL removes the use of CPDFSDK_Document from CPDFXFA_Document.

Committed:
https://pdfium.googlesource.com/pdfium/+/655fccab2f80af3a0e160116f30796e2da77...
==========

[commit-bot: I haz the power, 2016-10-11 20:53:42]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/655fccab2f80af3a0e160116f30796e2da77...