Added zone tracing

Added zone tracing

Added PrintF output whenever a zone is created or destroyed. Also
enables setting of a name for each zone, which can then be shown
in the v8-heap-stats tool: https://github.com/mlippautz/v8-heap-stats/pull/2

BUG=v8:5489
Committed: https://crrev.com/826451f078a300c4d31bd35cce799a64bedf94e1
Cr-Commit-Position: refs/heads/master@{#40168}

[heimbuef, 2016-10-11 11:23:42]

heimbuef@google.com changed reviewers:
+ mlippautz@chromium.org, verwaest@chromium.org

[heimbuef, 2016-10-11 11:23:43]

PTAL

[heimbuef, 2016-10-11 11:23:50]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 11:23:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[heimbuef, 2016-10-11 11:24:13]

Description was changed from

==========
Added zone tracing

Added PrintF output whenever a zone is created or destroyed. Also
enables setting of a name for each zone, which can then be shown
in the v8-heap-stats tool.

BUG=v8:5489
==========

to

==========
Added zone tracing

Added PrintF output whenever a zone is created or destroyed. Also
enables setting of a name for each zone, which can then be shown
in the v8-heap-stats tool: https://github.com/mlippautz/v8-heap-stats/pull/2

BUG=v8:5489
==========

[Michael Lippautz, 2016-10-11 11:25:20]

lgtm once comment is addressed.

https://codereview.chromium.org/2397573007/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2397573007/diff/1/src/isolate.cc#newcode2027
src/isolate.cc:2027: base::AtomicWord nesting_deepth_;
You should use base::AtomicNumber<size_t/intptr_t> here.

[heimbuef, 2016-10-11 12:03:12]

On 2016/10/11 at 11:25:20, mlippautz wrote:
> lgtm once comment is addressed.
> 
> https://codereview.chromium.org/2397573007/diff/1/src/isolate.cc
> File src/isolate.cc (right):
> 
> https://codereview.chromium.org/2397573007/diff/1/src/isolate.cc#newcode2027
> src/isolate.cc:2027: base::AtomicWord nesting_deepth_;
> You should use base::AtomicNumber<size_t/intptr_t> here.

Done.

[heimbuef, 2016-10-11 12:04:03]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-10-11 12:04:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2397573007/#ps20001
(title: "Reaction to comments")

[Toon Verwaest, 2016-10-11 12:04:10]

lgtm with additional comment

https://codereview.chromium.org/2397573007/diff/20001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2397573007/diff/20001/src/isolate.cc#newcode1938
src/isolate.cc:1938: nesting_deepth_(0),
nesting_depth

[commit-bot: I haz the power, 2016-10-11 12:04:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 12:36:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-11 12:37:16]

Description was changed from

==========
Added zone tracing

Added PrintF output whenever a zone is created or destroyed. Also
enables setting of a name for each zone, which can then be shown
in the v8-heap-stats tool: https://github.com/mlippautz/v8-heap-stats/pull/2

BUG=v8:5489
==========

to

==========
Added zone tracing

Added PrintF output whenever a zone is created or destroyed. Also
enables setting of a name for each zone, which can then be shown
in the v8-heap-stats tool: https://github.com/mlippautz/v8-heap-stats/pull/2

BUG=v8:5489

Committed: https://crrev.com/826451f078a300c4d31bd35cce799a64bedf94e1
Cr-Commit-Position: refs/heads/master@{#40168}
==========

[commit-bot: I haz the power, 2016-10-11 12:37:17]

Patchset 2 (id:??) landed as
https://crrev.com/826451f078a300c4d31bd35cce799a64bedf94e1
Cr-Commit-Position: refs/heads/master@{#40168}