Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2394213003: Named all zones in the project (Closed)

Created:
4 years, 2 months ago by heimbuef
Modified:
4 years, 2 months ago
CC:
rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Named all zones in the project This adds more useful information to the v8-heap-stats tool. BUG=v8:5489 Committed: https://crrev.com/e7fa9b0129586f9b7c7b2874eff24014ecf1a62a Cr-Commit-Position: refs/heads/master@{#40361}

Patch Set 1 #

Patch Set 2 : Made zone constructor non-explicite #

Patch Set 3 : Added missing zone name #

Patch Set 4 : Merge branch 'master' into zonenames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -283 lines) Patch
M src/background-parsing-task.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-replay.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-visualizer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/jump-threading.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 8 chunks +16 lines, -16 lines 0 comments Download
M src/compiler/type-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/verifier.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/zone-stats.h View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/zone-stats.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/compilation-phase.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/lithium-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-scopes.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/debug/liveedit.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/fast-accessor-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/gdb-jit.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/json-parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/keys.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/jsregexp.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-regexp.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/value-serializer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/ast-decoder.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-js.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/zone/zone.h View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M test/cctest/cctest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/code-assembler-tester.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/function-tester.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-loop-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-multiple-return.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-node.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 23 chunks +23 lines, -23 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 2 22 chunks +22 lines, -22 lines 0 comments Download
M test/cctest/test-ast.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-ast-types.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-bit-vector.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 22 chunks +22 lines, -22 lines 0 comments Download
M test/cctest/test-regexp.cc View 27 chunks +27 lines, -27 lines 0 comments Download
M test/cctest/test-run-wasm-relocation-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-run-wasm-relocation-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-types.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unique.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 2 3 17 chunks +17 lines, -17 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M test/common/wasm/wasm-module-runner.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M test/fuzzer/parser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/fuzzer/wasm-code.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/fuzzer/wasm-section-fuzzers.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/loop-peeling-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/zone-stats-unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M test/unittests/test-utils.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/parser-shell.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 34 (15 generated)
heimbuef
PTAL; we might need more owners as reviewers or circumvent the checks.
4 years, 2 months ago (2016-10-11 11:25:00 UTC) #3
Toon Verwaest
lgtm
4 years, 2 months ago (2016-10-11 12:13:05 UTC) #4
Yang
On 2016/10/11 12:13:05, Toon Verwaest wrote: > lgtm lgtm.
4 years, 2 months ago (2016-10-11 13:00:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394213003/20001
4 years, 2 months ago (2016-10-11 13:29:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/14324) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-11 13:33:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394213003/40001
4 years, 2 months ago (2016-10-11 14:57:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26161)
4 years, 2 months ago (2016-10-11 15:05:42 UTC) #14
titzer
On 2016/10/11 15:05:42, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-10-12 11:22:18 UTC) #16
heimbuef
On 2016/10/12 at 11:22:18, titzer wrote: > On 2016/10/11 15:05:42, commit-bot: I haz the power ...
4 years, 2 months ago (2016-10-12 12:20:25 UTC) #17
titzer
On 2016/10/12 12:20:25, heimbuef wrote: > On 2016/10/12 at 11:22:18, titzer wrote: > > On ...
4 years, 2 months ago (2016-10-12 12:41:59 UTC) #18
marja
lgtm
4 years, 2 months ago (2016-10-12 12:52:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394213003/40001
4 years, 2 months ago (2016-10-12 14:20:05 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26292)
4 years, 2 months ago (2016-10-12 14:25:14 UTC) #23
Benedikt Meurer
LGTM (rubber-stamped)
4 years, 2 months ago (2016-10-12 17:29:48 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394213003/40001
4 years, 2 months ago (2016-10-14 10:40:21 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/26365) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-14 10:42:11 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394213003/60001
4 years, 2 months ago (2016-10-17 11:43:10 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-17 12:12:40 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 12:12:52 UTC) #34
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e7fa9b0129586f9b7c7b2874eff24014ecf1a62a
Cr-Commit-Position: refs/heads/master@{#40361}

Powered by Google App Engine
This is Rietveld 408576698