Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2392183004: Added zone pool metrics to gc-trace. (Closed)

Created:
4 years, 2 months ago by heimbuef
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Added zone pool metrics to gc-trace. Can be displayed in the external tool as well. BUG=v8:5489 Committed: https://crrev.com/91a3517e24624776bd894b047190e600d18363be Cr-Commit-Position: refs/heads/master@{#40166}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reaction to comments #

Patch Set 3 : Added recent master changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -22 lines) Patch
M src/isolate.cc View 1 3 chunks +35 lines, -18 lines 0 comments Download
M src/zone/accounting-allocator.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/zone/accounting-allocator.cc View 3 chunks +7 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
heimbuef
PTAL. Please also see the matching pull request on github: https://github.com/mlippautz/v8-heap-stats/pull/1
4 years, 2 months ago (2016-10-06 12:18:13 UTC) #2
Michael Lippautz
LGTM once the comment is addressed If you plan more changes you should probably open ...
4 years, 2 months ago (2016-10-06 12:41:18 UTC) #3
heimbuef
On 2016/10/06 at 12:41:18, mlippautz wrote: > LGTM once the comment is addressed > > ...
4 years, 2 months ago (2016-10-06 12:44:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392183004/40001
4 years, 2 months ago (2016-10-11 11:20:08 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-11 11:49:35 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 11:49:57 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/91a3517e24624776bd894b047190e600d18363be
Cr-Commit-Position: refs/heads/master@{#40166}

Powered by Google App Engine
This is Rietveld 408576698