third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py - Issue 2397573002: Don't track SCM changes in rebaseline commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Issue 2397573002: Don't track SCM changes in rebaseline commands. (Closed)

Patch Set: Update message and docstring for has_working_directory_changes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

index 024162dc37c6be2fa53951d10c8a2cbad46b6a6b..7561bd5d0e6274e5a3140f61a14c54ed02c169d0 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

@@ -88,7 +88,6 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):

def test_execute_with_issue_number_given(self):

self.command.execute(self.command_options(issue=11112222), [], self.tool)

- print self._log.messages()

self.assertLog([

'INFO: Tests to rebaseline:\n',

'INFO: svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html: MOCK Try Win (5000)\n',

@@ -177,5 +176,5 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):

'--builder', 'MOCK Try Win', '--test', 'fast/dom/prototype-taco.html']],

[['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt',

'--builder', 'MOCK Try Win', '--test', 'fast/dom/prototype-taco.html', '--build-number', '5000']],

- [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '--suffixes', 'txt', 'fast/dom/prototype-taco.html']]

+ [['python', 'echo', 'optimize-baselines', '--suffixes', 'txt', 'fast/dom/prototype-taco.html']]

])