Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Issue 2397573002: Don't track SCM changes in rebaseline commands. (Closed)
Patch Set: Update message and docstring for has_working_directory_changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import json 5 import json
6 import optparse 6 import optparse
7 7
8 from webkitpy.common.net.buildbot import Build 8 from webkitpy.common.net.buildbot import Build
9 from webkitpy.common.net.rietveld import Rietveld 9 from webkitpy.common.net.rietveld import Rietveld
10 from webkitpy.common.net.web_mock import MockWeb 10 from webkitpy.common.net.web_mock import MockWeb
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 'optimize': True, 81 'optimize': True,
82 'results_directory': None, 82 'results_directory': None,
83 'verbose': False, 83 'verbose': False,
84 'trigger_jobs': False, 84 'trigger_jobs': False,
85 } 85 }
86 options.update(kwargs) 86 options.update(kwargs)
87 return optparse.Values(dict(**options)) 87 return optparse.Values(dict(**options))
88 88
89 def test_execute_with_issue_number_given(self): 89 def test_execute_with_issue_number_given(self):
90 self.command.execute(self.command_options(issue=11112222), [], self.tool ) 90 self.command.execute(self.command_options(issue=11112222), [], self.tool )
91 print self._log.messages()
92 self.assertLog([ 91 self.assertLog([
93 'INFO: Tests to rebaseline:\n', 92 'INFO: Tests to rebaseline:\n',
94 'INFO: svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation -attr.html: MOCK Try Win (5000)\n', 93 'INFO: svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation -attr.html: MOCK Try Win (5000)\n',
95 'INFO: fast/dom/prototype-inheritance.html: MOCK Try Win (5000)\n' , 94 'INFO: fast/dom/prototype-inheritance.html: MOCK Try Win (5000)\n' ,
96 'INFO: fast/dom/prototype-taco.html: MOCK Try Win (5000)\n', 95 'INFO: fast/dom/prototype-taco.html: MOCK Try Win (5000)\n',
97 'INFO: Rebaselining fast/dom/prototype-inheritance.html\n', 96 'INFO: Rebaselining fast/dom/prototype-inheritance.html\n',
98 'INFO: Rebaselining fast/dom/prototype-taco.html\n', 97 'INFO: Rebaselining fast/dom/prototype-taco.html\n',
99 'INFO: Rebaselining svg/dynamic-updates/SVGFEDropShadowElement-dom-s tdDeviation-attr.html\n', 98 'INFO: Rebaselining svg/dynamic-updates/SVGFEDropShadowElement-dom-s tdDeviation-attr.html\n',
100 ]) 99 ])
101 100
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 self.command_options(issue=11112222), 169 self.command_options(issue=11112222),
171 {"fast/dom/prototype-taco.html": {Build("MOCK Try Win", 5000): ["txt ", "png"]}}) 170 {"fast/dom/prototype-taco.html": {Build("MOCK Try Win", 5000): ["txt ", "png"]}})
172 171
173 self.assertEqual( 172 self.assertEqual(
174 self.tool.executive.calls, 173 self.tool.executive.calls,
175 [ 174 [
176 [['python', 'echo', 'copy-existing-baselines-internal', '--suffi xes', 'txt', 175 [['python', 'echo', 'copy-existing-baselines-internal', '--suffi xes', 'txt',
177 '--builder', 'MOCK Try Win', '--test', 'fast/dom/prototype-tac o.html']], 176 '--builder', 'MOCK Try Win', '--test', 'fast/dom/prototype-tac o.html']],
178 [['python', 'echo', 'rebaseline-test-internal', '--suffixes', 't xt', 177 [['python', 'echo', 'rebaseline-test-internal', '--suffixes', 't xt',
179 '--builder', 'MOCK Try Win', '--test', 'fast/dom/prototype-tac o.html', '--build-number', '5000']], 178 '--builder', 'MOCK Try Win', '--test', 'fast/dom/prototype-tac o.html', '--build-number', '5000']],
180 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', 'txt', 'fast/dom/prototype-taco.html']] 179 [['python', 'echo', 'optimize-baselines', '--suffixes', 'txt', ' fast/dom/prototype-taco.html']]
181 ]) 180 ])
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698