Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Issue 2397573002: Don't track SCM changes in rebaseline commands. (Closed)
Patch Set: Update message and docstring for has_working_directory_changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
index f59a5b3824cb82e30deef1bcf2ee13d7c8f5d4f9..b641698a698b7a996d2a683a686cfbedef17a1b6 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
@@ -76,17 +76,13 @@ class RebaselineCL(AbstractParallelRebaselineCommand):
# TODO(qyearsley): Fix places where non-existing tests may be added:
# 1. Make sure that the tests obtained when passing --only-changed-tests include only existing tests.
- # 2. Make sure that update-w3c-test-expectations doesn't specify non-existing tests (http://crbug.com/649691).
test_prefix_list = self._filter_existing(test_prefix_list)
self._log_test_prefix_list(test_prefix_list)
if options.dry_run:
return
- # NOTE(qyearsley): If this is changed to stage all new files with git,
- # e.g. if update_scm is not False, then update_w3c_test_expectations.py
- # should be changed to not call git add --all.
- self.rebaseline(options, test_prefix_list, update_scm=False)
+ self.rebaseline(options, test_prefix_list)
def _filter_existing(self, test_prefix_list):
"""Filters out entries in |test_prefix_list| for tests that don't exist."""

Powered by Google App Engine
This is Rietveld 408576698