Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2397513003: Remove m_pOccontent from CPDFSDK_Document (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove m_pOccontent from CPDFSDK_Document Unused, remove. Committed: https://pdfium.googlesource.com/pdfium/+/f7ca7302bed831801a0b81ff4e1222c75833d2d6

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M fpdfsdk/cpdfsdk_document.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M fpdfsdk/cpdfsdk_document.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-05 16:03:48 UTC) #4
Tom Sepez
Dead code is best code. LGTM.
4 years, 2 months ago (2016-10-05 16:40:17 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2391313002 Patch 1). Please resolve the dependency and ...
4 years, 2 months ago (2016-10-05 16:40:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397513003/40001
4 years, 2 months ago (2016-10-05 22:47:23 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 22:47:33 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/f7ca7302bed831801a0b81ff4e1222c75833...

Powered by Google App Engine
This is Rietveld 408576698