Rename CPDFSDK_Environment to CPDFSDK_FormfillEnvironment

Rename CPDFSDK_Environment to CPDFSDK_FormfillEnvironment

Rename CPDFSDK_Environment to make it explicit that this is part of the formfill
system.

Committed: https://pdfium.googlesource.com/pdfium/+/735606d84b6898a51c61b17a2d286a13d964589a

[dsinclair, 2016-10-05 15:58:39]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 15:58:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-05 15:58:49]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-10-05 15:58:49]

PTAL.

[commit-bot: I haz the power, 2016-10-05 16:11:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 16:11:22]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-05 16:38:18]

https://codereview.chromium.org/2391313002/diff/1/fpdfsdk/cpdfsdk_formfillenv...
File fpdfsdk/cpdfsdk_formfillenvironment.h (right):

https://codereview.chromium.org/2391313002/diff/1/fpdfsdk/cpdfsdk_formfillenv...
fpdfsdk/cpdfsdk_formfillenvironment.h:28: class CPDFSDK_FormfillEnvironment
final {
nit: FormFillEnvironment to be consistent with other usage:

$ git grep Formfill | wc
      1       3      48
$ git grep FormFill | wc
    387    1559   37385

[dsinclair, 2016-10-05 17:59:21]

https://codereview.chromium.org/2391313002/diff/1/fpdfsdk/cpdfsdk_formfillenv...
File fpdfsdk/cpdfsdk_formfillenvironment.h (right):

https://codereview.chromium.org/2391313002/diff/1/fpdfsdk/cpdfsdk_formfillenv...
fpdfsdk/cpdfsdk_formfillenvironment.h:28: class CPDFSDK_FormfillEnvironment
final {
On 2016/10/05 16:38:18, Tom Sepez wrote:
> nit: FormFillEnvironment to be consistent with other usage:
> 
> $ git grep Formfill | wc
>       1       3      48
> $ git grep FormFill | wc
>     387    1559   37385

Done.

[dsinclair, 2016-10-05 20:29:29]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 20:29:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-05 20:44:31]

LGTM with a few suggestions you may want to try. or not.

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/cpdfsdk_pagevie...
File fpdfsdk/cpdfsdk_pageview.cpp (right):

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/cpdfsdk_pagevie...
fpdfsdk/cpdfsdk_pageview.cpp:68: CPDFSDK_FormFillEnvironment* pEnv =
m_pSDKDoc->GetEnv();
nit: can we call this method m_pSDKDoc->GetFormFillEnvironment();

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/cpdfsdk_xfawidg...
File fpdfsdk/cpdfsdk_xfawidgethandler.h (right):

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/cpdfsdk_xfawidg...
fpdfsdk/cpdfsdk_xfawidgethandler.h:105: CPDFSDK_FormFillEnvironment* m_pEnv;
nit: can we call this m_pFormFillEnvironment?

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/formfiller/cffl...
File fpdfsdk/formfiller/cffl_formfiller.h (right):

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/formfiller/cffl...
fpdfsdk/formfiller/cffl_formfiller.h:164: CPDFSDK_FormFillEnvironment* m_pEnv;
ditto

[dsinclair, 2016-10-05 20:47:13]

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/cpdfsdk_pagevie...
File fpdfsdk/cpdfsdk_pageview.cpp (right):

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/cpdfsdk_pagevie...
fpdfsdk/cpdfsdk_pageview.cpp:68: CPDFSDK_FormFillEnvironment* pEnv =
m_pSDKDoc->GetEnv();
On 2016/10/05 20:44:31, Tom Sepez wrote:
> nit: can we call this method m_pSDKDoc->GetFormFillEnvironment();


My plan is htat m_pSDKDoc will not exist in the future. So, I'm not bothering to
rename this one as it will, hopefully, go away.

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/cpdfsdk_xfawidg...
File fpdfsdk/cpdfsdk_xfawidgethandler.h (right):

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/cpdfsdk_xfawidg...
fpdfsdk/cpdfsdk_xfawidgethandler.h:105: CPDFSDK_FormFillEnvironment* m_pEnv;
On 2016/10/05 20:44:31, Tom Sepez wrote:
> nit: can we call this m_pFormFillEnvironment?


Future patch makes it m_pFormFillEnv which is a bit shorter but better then
m_pEnv.

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/formfiller/cffl...
File fpdfsdk/formfiller/cffl_formfiller.h (right):

https://codereview.chromium.org/2391313002/diff/40001/fpdfsdk/formfiller/cffl...
fpdfsdk/formfiller/cffl_formfiller.h:164: CPDFSDK_FormFillEnvironment* m_pEnv;
On 2016/10/05 20:44:31, Tom Sepez wrote:
> ditto

ditto ditto.

[commit-bot: I haz the power, 2016-10-05 20:50:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 20:50:39]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-10-05 22:46:35]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:46:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 22:47:04]

Description was changed from

==========
Rename CPDFSDK_Environment to CPDFSDK_FormfillEnvironment

Rename CPDFSDK_Environment to make it explicit that this is part of the formfill
system.
==========

to

==========
Rename CPDFSDK_Environment to CPDFSDK_FormfillEnvironment

Rename CPDFSDK_Environment to make it explicit that this is part of the formfill
system.

Committed:
https://pdfium.googlesource.com/pdfium/+/735606d84b6898a51c61b17a2d286a13d964...
==========

[commit-bot: I haz the power, 2016-10-05 22:47:05]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/735606d84b6898a51c61b17a2d286a13d964...