Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2400473002: Start proxying CPDFSDK_Document methods through CPDFSDK_FormFillEnvironment (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Start proxying CPDFSDK_Document methods through CPDFSDK_FormFillEnvironment This CL proxies the GetInterForm() and GetXFADocument() methods through the FormFillEnvironment. It also updates a few classes to return the form fill environment instead of the sdk document. This is the first step in merging the CPDFSDK_Document into the CPDFSDK_FormFillEnvironment.

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -310 lines) Patch
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_document.h View 3 chunks +9 lines, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.h View 3 chunks +14 lines, -0 lines 0 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.h View 2 chunks +5 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.h View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 17 chunks +39 lines, -37 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 15 chunks +23 lines, -39 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 5 chunks +10 lines, -11 lines 0 comments Download
M fpdfsdk/formfiller/cffl_interactiveformfiller.h View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_interactiveformfiller.cpp View 19 chunks +41 lines, -42 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 9 chunks +18 lines, -18 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 25 chunks +107 lines, -102 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_document.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_document.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 18 chunks +19 lines, -18 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/app.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
dsinclair
PTAL. This starts the process of merging CPDFSDK_Document into CPDFSDK_FormFillEnvironment with the eventual goal that ...
4 years, 2 months ago (2016-10-05 20:00:03 UTC) #2
dsinclair
4 years, 2 months ago (2016-10-06 13:59:43 UTC) #11
On 2016/10/06 13:52:52, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Closing this for a different approach.

Powered by Google App Engine
This is Rietveld 408576698