[heap] Use the thread-safe free modes also for RemoveRange in SlotSet.

[heap] Use the thread-safe free modes also for RemoveRange in SlotSet.

BUG=chromium:648568
Committed: https://crrev.com/e5b07adfb1ddd3db95bed1d166547c54a501ef8b
Cr-Commit-Position: refs/heads/master@{#40075}

[Hannes Payer (out of office), 2016-10-07 07:44:25]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 07:44:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-10-07 07:50:57]

hpayer@chromium.org changed reviewers:
+ mlippautz@chromium.org, ulan@chromium.org

[Hannes Payer (out of office), 2016-10-07 07:50:57]

https://codereview.chromium.org/2397373002/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2397373002/diff/1/src/heap/heap.cc#newcode5968
src/heap/heap.cc:5968: RememberedSet<OLD_TO_OLD>::RemoveRange(page, start, end,
I added an additional mode here because old to old will never have concurrent
access and can be freed directly. However, it may be beneficial to never
deallocate on the main thread an push the work to concurrent tasks. Any
thoughts?

[commit-bot: I haz the power, 2016-10-07 08:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 08:10:49]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-10-07 09:11:06]

lgtm

https://codereview.chromium.org/2397373002/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2397373002/diff/1/src/heap/heap.cc#newcode5968
src/heap/heap.cc:5968: RememberedSet<OLD_TO_OLD>::RemoveRange(page, start, end,
On 2016/10/07 07:50:57, Hannes Payer wrote:
> I added an additional mode here because old to old will never have concurrent
> access and can be freed directly. However, it may be beneficial to never
> deallocate on the main thread an push the work to concurrent tasks. Any
> thoughts?

Even if there's not concurrent access, I would in the end try to free them at
the same place, i.e., I would deallocate them in the sweeper.

[Hannes Payer (out of office), 2016-10-07 09:12:45]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2016-10-07 09:12:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 09:15:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-07 09:16:13]

Description was changed from

==========
[heap] Use the thread-safe free modes also for RemoveRange in SlotSet.

BUG=chromium:648568
==========

to

==========
[heap] Use the thread-safe free modes also for RemoveRange in SlotSet.

BUG=chromium:648568

Committed: https://crrev.com/e5b07adfb1ddd3db95bed1d166547c54a501ef8b
Cr-Commit-Position: refs/heads/master@{#40075}
==========

[commit-bot: I haz the power, 2016-10-07 09:16:14]

Patchset 1 (id:??) landed as
https://crrev.com/e5b07adfb1ddd3db95bed1d166547c54a501ef8b
Cr-Commit-Position: refs/heads/master@{#40075}