Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: test/cctest/heap/test-heap.cc

Issue 2397373002: [heap] Use the thread-safe free modes also for RemoveRange in SlotSet. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index c69d391f90f399385d74ff0372c24a93970f46b5..b722f54eedef131f2877ade7258c2d6e62456a66 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -7077,7 +7077,8 @@ TEST(RememberedSetRemoveRange) {
return KEEP_SLOT;
});
- RememberedSet<OLD_TO_NEW>::RemoveRange(chunk, start, start + kPointerSize);
+ RememberedSet<OLD_TO_NEW>::RemoveRange(chunk, start, start + kPointerSize,
+ SlotSet::FREE_EMPTY_BUCKETS);
slots[start] = false;
RememberedSet<OLD_TO_NEW>::Iterate(chunk, [&slots](Address addr) {
CHECK(slots[addr]);
@@ -7085,7 +7086,8 @@ TEST(RememberedSetRemoveRange) {
});
RememberedSet<OLD_TO_NEW>::RemoveRange(chunk, start + kPointerSize,
- start + Page::kPageSize);
+ start + Page::kPageSize,
+ SlotSet::FREE_EMPTY_BUCKETS);
slots[start + kPointerSize] = false;
slots[start + Page::kPageSize - kPointerSize] = false;
RememberedSet<OLD_TO_NEW>::Iterate(chunk, [&slots](Address addr) {
@@ -7093,8 +7095,9 @@ TEST(RememberedSetRemoveRange) {
return KEEP_SLOT;
});
- RememberedSet<OLD_TO_NEW>::RemoveRange(
- chunk, start, start + Page::kPageSize + kPointerSize);
+ RememberedSet<OLD_TO_NEW>::RemoveRange(chunk, start,
+ start + Page::kPageSize + kPointerSize,
+ SlotSet::FREE_EMPTY_BUCKETS);
slots[start + Page::kPageSize] = false;
RememberedSet<OLD_TO_NEW>::Iterate(chunk, [&slots](Address addr) {
CHECK(slots[addr]);
@@ -7102,7 +7105,8 @@ TEST(RememberedSetRemoveRange) {
});
RememberedSet<OLD_TO_NEW>::RemoveRange(
- chunk, chunk->area_end() - kPointerSize, chunk->area_end());
+ chunk, chunk->area_end() - kPointerSize, chunk->area_end(),
+ SlotSet::FREE_EMPTY_BUCKETS);
slots[chunk->area_end() - kPointerSize] = false;
RememberedSet<OLD_TO_NEW>::Iterate(chunk, [&slots](Address addr) {
CHECK(slots[addr]);

Powered by Google App Engine
This is Rietveld 408576698