Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2397093002: IDL compiler should generate equalIgnoringASCIICase() for ReflectOnly. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
haraken, peria, bashi, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IDL compiler should generate equalIgnoringASCIICase() for ReflectOnly. https://html.spec.whatwg.org/multipage/infrastructure.html#keywords-and-enumerated-attributes > If an enumerated attribute is specified, the attribute's value must be an ASCII > case-insensitive match ... BUG=627682 Committed: https://crrev.com/781a2223b6141009b6f02e8cb3e9d916feacf089 Cr-Commit-Position: refs/heads/master@{#423466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -18 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/referrer-policy-attribute-reflect.html View 1 chunk +55 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 7 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
tkent
Binding guys, would you review this please?
4 years, 2 months ago (2016-10-06 03:34:54 UTC) #5
bashi
lgtm
4 years, 2 months ago (2016-10-06 03:47:07 UTC) #6
haraken
LGTM
4 years, 2 months ago (2016-10-06 03:52:56 UTC) #7
peria
4 years, 2 months ago (2016-10-06 04:01:56 UTC) #9
peria
lgtm
4 years, 2 months ago (2016-10-06 04:02:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397093002/1
4 years, 2 months ago (2016-10-06 05:55:40 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 07:11:56 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 07:15:53 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/781a2223b6141009b6f02e8cb3e9d916feacf089
Cr-Commit-Position: refs/heads/master@{#423466}

Powered by Google App Engine
This is Rietveld 408576698