third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl - Issue 2397093002: IDL compiler should generate equalIgnoringASCIICase() for ReflectOnly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

Issue 2397093002: IDL compiler should generate equalIgnoringASCIICase() for ReflectOnly. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

index 60f0d393b675c42ebdbdd406b6df535034db17ce..72d98ec4b135eb1e224c00abb2a958b255f2d867 100644

--- a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

@@ -184,7 +184,7 @@ if ({{cpp_value}}.isEmpty()) {

{% endif %}

{% for value in reflect_only_values %}

-} else if (equalIgnoringCase({{cpp_value}}, "{{value}}")) {

+} else if (equalIgnoringASCIICase({{cpp_value}}, "{{value}}")) {

{{cpp_value}} = "{{value}}";

{% endfor %}

} else {