Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

Issue 2397093002: IDL compiler should generate equalIgnoringASCIICase() for ReflectOnly. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% from 'utilities.cpp.tmpl' import declare_enum_validation_variable, v8_value_t o_local_cpp_value %} 1 {% from 'utilities.cpp.tmpl' import declare_enum_validation_variable, v8_value_t o_local_cpp_value %}
2 2
3 {##############################################################################} 3 {##############################################################################}
4 {% macro attribute_getter(attribute, world_suffix) %} 4 {% macro attribute_getter(attribute, world_suffix) %}
5 static void {{attribute.name}}AttributeGetter{{world_suffix}}( 5 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
6 {%- if attribute.is_data_type_property %} 6 {%- if attribute.is_data_type_property %}
7 const v8::PropertyCallbackInfo<v8::Value>& info 7 const v8::PropertyCallbackInfo<v8::Value>& info
8 {%- else %} 8 {%- else %}
9 const v8::FunctionCallbackInfo<v8::Value>& info 9 const v8::FunctionCallbackInfo<v8::Value>& info
10 {%- endif %}) 10 {%- endif %})
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 {% else %} 177 {% else %}
178 if ({{cpp_value}}.isEmpty()) { 178 if ({{cpp_value}}.isEmpty()) {
179 {# FIXME: should use [ReflectEmpty] instead; need to change IDL files #} 179 {# FIXME: should use [ReflectEmpty] instead; need to change IDL files #}
180 {% if reflect_missing %} 180 {% if reflect_missing %}
181 {{cpp_value}} = "{{reflect_missing}}"; 181 {{cpp_value}} = "{{reflect_missing}}";
182 {% else %} 182 {% else %}
183 ; 183 ;
184 {% endif %} 184 {% endif %}
185 {% endif %} 185 {% endif %}
186 {% for value in reflect_only_values %} 186 {% for value in reflect_only_values %}
187 } else if (equalIgnoringCase({{cpp_value}}, "{{value}}")) { 187 } else if (equalIgnoringASCIICase({{cpp_value}}, "{{value}}")) {
188 {{cpp_value}} = "{{value}}"; 188 {{cpp_value}} = "{{value}}";
189 {% endfor %} 189 {% endfor %}
190 } else { 190 } else {
191 {{cpp_value}} = "{{reflect_invalid}}"; 191 {{cpp_value}} = "{{reflect_invalid}}";
192 } 192 }
193 {% endmacro %} 193 {% endmacro %}
194 194
195 195
196 {##############################################################################} 196 {##############################################################################}
197 {% macro attribute_getter_callback(attribute, world_suffix) %} 197 {% macro attribute_getter_callback(attribute, world_suffix) %}
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 setter_callback_for_main_world, 521 setter_callback_for_main_world,
522 wrapper_type_info, 522 wrapper_type_info,
523 access_control, 523 access_control,
524 property_attribute, 524 property_attribute,
525 only_exposed_to_private_script, 525 only_exposed_to_private_script,
526 property_location(attribute), 526 property_location(attribute),
527 holder_check, 527 holder_check,
528 ] %} 528 ] %}
529 {{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}} 529 {{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}}
530 {%- endmacro %} 530 {%- endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698