|
|
Rename Node::lastDescendant() / Node::highestAncestor() for clarity
Rename Node::lastDescendant() / Node::highestAncestor() to
Node::lastDescendantOrSelf() / Node::highestAncestorOrSelf() for clarity.
Previously, it was not obvious that these methods was returning the current Node
if it has no descendant / ancestor. Callers interested in the last descendant
per say should be using NodeTraversal::lastWithin().
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171793
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+23 lines, -23 lines) |
Patch |
 |
M |
Source/core/dom/ContainerNode.h
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/dom/Node.h
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/Node.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/editing/ApplyStyleCommand.cpp
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/editing/DeleteSelectionCommand.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/editing/ReplaceSelectionCommand.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/editing/ReplaceSelectionCommand.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/editing/VisibleUnits.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/html/FormAssociatedElement.cpp
|
View
|
1
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLFormElement.cpp
|
View
|
1
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLImageElement.cpp
|
View
|
1
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/inspector/PageConsoleAgent.cpp
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/xml/XPathPath.cpp
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 6 (0 generated)
|
Chromium Code Reviews
Issue
239703007:
Rename Node::lastDescendant() / Node::highestAncestor() for clarity (Closed)
