Source/core/inspector/PageConsoleAgent.cpp - Issue 239703007: Rename Node::lastDescendant() / Node::highestAncestor() for clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/PageConsoleAgent.cpp

Issue 239703007: Rename Node::lastDescendant() / Node::highestAncestor() for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rename highestAncestor() as well Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/PageConsoleAgent.cpp

diff --git a/Source/core/inspector/PageConsoleAgent.cpp b/Source/core/inspector/PageConsoleAgent.cpp

index 195f16caa42b9ba6a152fb22f95a2f9d6cc5c477..dfa5c70898f555637fd881f7c5bc74a2f3f79b17 100644

--- a/Source/core/inspector/PageConsoleAgent.cpp

+++ b/Source/core/inspector/PageConsoleAgent.cpp

@@ -75,7 +75,7 @@ void PageConsoleAgent::addInspectedNode(ErrorString* errorString, int nodeId)

return;

}

while (node->isInShadowTree()) {

- Node& ancestor = node->highestAncestor();

+ Node& ancestor = node->highestAncestorOrSelf();

if (!ancestor.isShadowRoot() || toShadowRoot(ancestor).type() == ShadowRoot::AuthorShadowRoot)

break;

// User agent shadow root, keep climbing up.

« no previous file with comments | « Source/core/html/HTMLImageElement.cpp ('k') | Source/core/xml/XPathPath.cpp » ('j') | no next file with comments »