Source/core/editing/VisibleUnits.cpp - Issue 239703007: Rename Node::lastDescendant() / Node::highestAncestor() for clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleUnits.cpp

Issue 239703007: Rename Node::lastDescendant() / Node::highestAncestor() for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rename highestAncestor() as well Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/VisibleUnits.cpp

diff --git a/Source/core/editing/VisibleUnits.cpp b/Source/core/editing/VisibleUnits.cpp

index 78746f5c510b6129d4b5c5c49ab75e33731425ee..9ffa0c86b26111f990102052a61108d09d4f7224 100644

--- a/Source/core/editing/VisibleUnits.cpp

+++ b/Source/core/editing/VisibleUnits.cpp

@@ -996,7 +996,7 @@ VisiblePosition nextLinePosition(const VisiblePosition &visiblePosition, int lin

if (!root) {

// FIXME: We need do the same in previousLinePosition.

Node* child = node->traverseToChildAt(p.deprecatedEditingOffset());

- node = child ? child : &node->lastDescendant();

+ node = child ? child : &node->lastDescendantOrSelf();

Position position = nextRootInlineBoxCandidatePosition(node, visiblePosition, editableType);

if (position.isNotNull()) {

RenderedPosition renderedPosition((VisiblePosition(position)));