Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2396963003: [parser] Deprecate ParseInfo constructor taking closure. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Deprecate ParseInfo constructor taking closure. This removes the {ParseInfo} constructor consuming a closure, replacing all uses to pass only the shared function info. The goal is to make the fact that parsing is independent of a concrete closure explicit. R=jochen@chromium.org BUG=v8:2206 Committed: https://crrev.com/3de42b3f224217ec88e4c609d3cf23fe06806dca Committed: https://crrev.com/ab5379074d152c5841148277bfdd63739ecb9a4a Cr-Original-Commit-Position: refs/heads/master@{#40083} Cr-Commit-Position: refs/heads/master@{#40353}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M src/compiler.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parse-info.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/parsing/parse-info.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/function-tester.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 41 (28 generated)
marja
lgtm
4 years, 2 months ago (2016-10-06 11:55:48 UTC) #5
Michael Starzinger
Jochen: PTAL at all the things. Marja: PTAL at "parsing". Yang: PTAL at "debug". Jaro: ...
4 years, 2 months ago (2016-10-06 12:03:52 UTC) #7
Benedikt Meurer
LGTM on Crankshaft.
4 years, 2 months ago (2016-10-07 10:23:41 UTC) #11
jochen (gone - plz use gerrit)
all the things lgtm
4 years, 2 months ago (2016-10-07 10:31:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396963003/1
4 years, 2 months ago (2016-10-07 10:35:01 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25918)
4 years, 2 months ago (2016-10-07 10:39:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396963003/20001
4 years, 2 months ago (2016-10-07 11:55:35 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 12:26:39 UTC) #26
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3de42b3f224217ec88e4c609d3cf23fe06806dca Cr-Commit-Position: refs/heads/master@{#40083}
4 years, 2 months ago (2016-10-07 12:27:04 UTC) #28
Michael Hablich
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2406623002/ by hablich@chromium.org. ...
4 years, 2 months ago (2016-10-07 21:13:03 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396963003/40001
4 years, 2 months ago (2016-10-17 10:24:45 UTC) #37
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 10:27:06 UTC) #39
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 10:27:33 UTC) #41
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab5379074d152c5841148277bfdd63739ecb9a4a
Cr-Commit-Position: refs/heads/master@{#40353}

Powered by Google App Engine
This is Rietveld 408576698