Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/crankshaft/hydrogen.cc

Issue 2396963003: [parser] Deprecate ParseInfo constructor taking closure. (Closed)
Patch Set: Rebased. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.h ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen.h" 5 #include "src/crankshaft/hydrogen.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/allocation-site-scopes.h" 10 #include "src/allocation-site-scopes.h"
(...skipping 8226 matching lines...) Expand 10 before | Expand all | Expand 10 after
8237 // Always inline small methods (<= 10 nodes). 8237 // Always inline small methods (<= 10 nodes).
8238 if (inlined_count_ > Min(FLAG_max_inlined_nodes_cumulative, 8238 if (inlined_count_ > Min(FLAG_max_inlined_nodes_cumulative,
8239 kUnlimitedMaxInlinedNodesCumulative)) { 8239 kUnlimitedMaxInlinedNodesCumulative)) {
8240 TraceInline(target, caller, "cumulative AST node limit reached"); 8240 TraceInline(target, caller, "cumulative AST node limit reached");
8241 return false; 8241 return false;
8242 } 8242 }
8243 8243
8244 // Parse and allocate variables. 8244 // Parse and allocate variables.
8245 // Use the same AstValueFactory for creating strings in the sub-compilation 8245 // Use the same AstValueFactory for creating strings in the sub-compilation
8246 // step, but don't transfer ownership to target_info. 8246 // step, but don't transfer ownership to target_info.
8247 ParseInfo parse_info(zone(), target); 8247 Handle<SharedFunctionInfo> target_shared(target->shared());
8248 ParseInfo parse_info(zone(), target_shared);
8248 parse_info.set_ast_value_factory( 8249 parse_info.set_ast_value_factory(
8249 top_info()->parse_info()->ast_value_factory()); 8250 top_info()->parse_info()->ast_value_factory());
8250 parse_info.set_ast_value_factory_owned(false); 8251 parse_info.set_ast_value_factory_owned(false);
8251 8252
8252 CompilationInfo target_info(&parse_info, target); 8253 CompilationInfo target_info(&parse_info, target);
8253 Handle<SharedFunctionInfo> target_shared(target->shared());
8254 8254
8255 if (inlining_kind != CONSTRUCT_CALL_RETURN && 8255 if (inlining_kind != CONSTRUCT_CALL_RETURN &&
8256 IsClassConstructor(target_shared->kind())) { 8256 IsClassConstructor(target_shared->kind())) {
8257 TraceInline(target, caller, "target is classConstructor"); 8257 TraceInline(target, caller, "target is classConstructor");
8258 return false; 8258 return false;
8259 } 8259 }
8260 8260
8261 if (target_shared->HasDebugInfo()) { 8261 if (target_shared->HasDebugInfo()) {
8262 TraceInline(target, caller, "target is being debugged"); 8262 TraceInline(target, caller, "target is being debugged");
8263 return false; 8263 return false;
(...skipping 5023 matching lines...) Expand 10 before | Expand all | Expand 10 after
13287 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13287 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13288 } 13288 }
13289 13289
13290 #ifdef DEBUG 13290 #ifdef DEBUG
13291 graph_->Verify(false); // No full verify. 13291 graph_->Verify(false); // No full verify.
13292 #endif 13292 #endif
13293 } 13293 }
13294 13294
13295 } // namespace internal 13295 } // namespace internal
13296 } // namespace v8 13296 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.h ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698