Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2400343002: Revert of Pool implementation for zone segments (Closed)

Created:
4 years, 2 months ago by Michael Hablich
Modified:
4 years, 2 months ago
CC:
rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Pool implementation for zone segments (patchset #13 id:520001 of https://codereview.chromium.org/2335343007/ ) Reason for revert: blocks roll: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/294283/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Pool implementation for zone segments > > BUG=v8:5409 > > Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e > Committed: https://crrev.com/316669f62ea3834395bf4caab7bc3d7c32f6bbc6 > Cr-Original-Commit-Position: refs/heads/master@{#39631} > Cr-Commit-Position: refs/heads/master@{#40044} TBR=jochen@chromium.org,jkummerow@chromium.org,verwaest@chromium.org,yangguo@chromium.org,heimbuef@google.com NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=v8:5409 Committed: https://crrev.com/f28e5dcbc4e6c53a6458f10736b881926d14aa03 Cr-Commit-Position: refs/heads/master@{#40100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -192 lines) Patch
M src/api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/zone/accounting-allocator.h View 1 chunk +4 lines, -40 lines 0 comments Download
M src/zone/accounting-allocator.cc View 3 chunks +0 lines, -120 lines 0 comments Download
M src/zone/zone.h View 4 chunks +11 lines, -3 lines 0 comments Download
M src/zone/zone.cc View 2 chunks +55 lines, -16 lines 0 comments Download
M src/zone/zone-segment.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/zone/zone-segment.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael Hablich
Created Revert of Pool implementation for zone segments
4 years, 2 months ago (2016-10-07 21:07:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400343002/1
4 years, 2 months ago (2016-10-07 21:07:35 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/10118) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-07 21:09:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400343002/1
4 years, 2 months ago (2016-10-07 21:18:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 21:19:06 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 21:19:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f28e5dcbc4e6c53a6458f10736b881926d14aa03
Cr-Commit-Position: refs/heads/master@{#40100}

Powered by Google App Engine
This is Rietveld 408576698