arc: Add action to IntentHandlerInfo and rename enum fields.

arc: Add action to IntentHandlerInfo and rename enum fields.

Rename IntentHandlerInfo's ActionType field from "action" to
"action_type" and add a new string "action" field. Update
Chrome to use the enum field's new name.

In the IntentHelperInstance interface, also rename
HandleUrlList and HandleUrlListDeprecated's ActionType
parameters from "action" to "action_type". The method
signatures remain unchanged.

BUG=647802
Committed: https://crrev.com/0caeced0be3bcfaeffa814ad4a62ea3a998458fd
Cr-Commit-Position: refs/heads/master@{#422994}

[Daniel Erat, 2016-10-04 21:04:29]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 21:05:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-10-04 21:05:24]

derat@chromium.org changed reviewers:
+ dcheng@chromium.org, lhchavez@chromium.org, yusukes@chromium.org

[commit-bot: I haz the power, 2016-10-04 21:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 21:44:41]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-10-04 22:29:11]

https://codereview.chromium.org/2396633002/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2396633002/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:51: [MinVersion=11] string? action; 
// e.g. "android.intent.action.VIEW"
How will this field be used?

[Daniel Erat, 2016-10-04 22:43:22]

https://codereview.chromium.org/2396633002/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2396633002/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:51: [MinVersion=11] string? action; 
// e.g. "android.intent.action.VIEW"
On 2016/10/04 22:29:11, dcheng wrote:
> How will this field be used?

i can document it in a comment if that'd be better, but i plan to remove
action_type and only use this field in order to support arbitrary intents
(http://crbug.com/647802). alternately, should i name the old field
"deprecated_action_type" instead?

[dcheng, 2016-10-04 22:49:41]

mojo lgtm

https://codereview.chromium.org/2396633002/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2396633002/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:51: [MinVersion=11] string? action; 
// e.g. "android.intent.action.VIEW"
On 2016/10/04 22:43:22, Daniel Erat wrote:
> On 2016/10/04 22:29:11, dcheng wrote:
> > How will this field be used?
> 
> i can document it in a comment if that'd be better, but i plan to remove
> action_type and only use this field in order to support arbitrary intents
> (http://crbug.com/647802). alternately, should i name the old field
> "deprecated_action_type" instead?

Usually, it's preferred to land this sort of change with something that's
actually using it (especially because for ipc reviews, it's preferred to use
something that's more strongly typed--like the current enum--over something less
loosely typed--like the newly added string field).

I assume that the ARC++ side is blocked on this CL landing though, so please
just CC an IPC reviewer on the followup CL that uses this in Chrome.

[Luis Héctor Chávez, 2016-10-04 22:53:29]

lgtm

[Daniel Erat, 2016-10-04 22:57:35]

https://codereview.chromium.org/2396633002/diff/1/components/arc/common/inten...
File components/arc/common/intent_helper.mojom (right):

https://codereview.chromium.org/2396633002/diff/1/components/arc/common/inten...
components/arc/common/intent_helper.mojom:51: [MinVersion=11] string? action; 
// e.g. "android.intent.action.VIEW"
On 2016/10/04 22:49:41, dcheng wrote:
> On 2016/10/04 22:43:22, Daniel Erat wrote:
> > On 2016/10/04 22:29:11, dcheng wrote:
> > > How will this field be used?
> > 
> > i can document it in a comment if that'd be better, but i plan to remove
> > action_type and only use this field in order to support arbitrary intents
> > (http://crbug.com/647802). alternately, should i name the old field
> > "deprecated_action_type" instead?
> 
> Usually, it's preferred to land this sort of change with something that's
> actually using it (especially because for ipc reviews, it's preferred to use
> something that's more strongly typed--like the current enum--over something
less
> loosely typed--like the newly added string field).
> 
> I assume that the ARC++ side is blocked on this CL landing though, so please
> just CC an IPC reviewer on the followup CL that uses this in Chrome.

got it. yeah, chrome can't use this until the android side sets it, and i
believe that mojom changes are supposed to land in chrome first. i could update
this change so chrome also uses the string if it's present and falls back to the
enum otherwise, but i figured that switching chrome to only use the string in a
later change might make reviews easier.

[Daniel Erat, 2016-10-04 23:14:34]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-10-04 23:15:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 23:22:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 23:25:36]

Description was changed from

==========
arc: Add action to IntentHandlerInfo and rename enum fields.

Rename IntentHandlerInfo's ActionType field from "action" to
"action_type" and add a new string "action" field. Update
Chrome to use the enum field's new name.

In the IntentHelperInstance interface, also rename
HandleUrlList and HandleUrlListDeprecated's ActionType
parameters from "action" to "action_type". The method
signatures remain unchanged.

BUG=647802
==========

to

==========
arc: Add action to IntentHandlerInfo and rename enum fields.

Rename IntentHandlerInfo's ActionType field from "action" to
"action_type" and add a new string "action" field. Update
Chrome to use the enum field's new name.

In the IntentHelperInstance interface, also rename
HandleUrlList and HandleUrlListDeprecated's ActionType
parameters from "action" to "action_type". The method
signatures remain unchanged.

BUG=647802

Committed: https://crrev.com/0caeced0be3bcfaeffa814ad4a62ea3a998458fd
Cr-Commit-Position: refs/heads/master@{#422994}
==========

[commit-bot: I haz the power, 2016-10-04 23:25:37]

Patchset 1 (id:??) landed as
https://crrev.com/0caeced0be3bcfaeffa814ad4a62ea3a998458fd
Cr-Commit-Position: refs/heads/master@{#422994}