Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: chrome/browser/chromeos/file_manager/arc_file_tasks.cc

Issue 2396633002: arc: Add action to IntentHandlerInfo and rename enum fields. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/arc/common/intent_helper.mojom » ('j') | components/arc/common/intent_helper.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_manager/arc_file_tasks.cc
diff --git a/chrome/browser/chromeos/file_manager/arc_file_tasks.cc b/chrome/browser/chromeos/file_manager/arc_file_tasks.cc
index 6de7d978f7c24a305c091ee3146e41f1ca753345..1f9ae8c6630e6a28f485f4d317fc3828b50de193 100644
--- a/chrome/browser/chromeos/file_manager/arc_file_tasks.cc
+++ b/chrome/browser/chromeos/file_manager/arc_file_tasks.cc
@@ -75,8 +75,8 @@ scoped_refptr<arc::ActivityIconLoader> GetArcActivityIconLoader() {
return arc_service_manager->icon_loader();
}
-std::string ArcActionToString(arc::mojom::ActionType action) {
- switch (action) {
+std::string ArcActionTypeToString(arc::mojom::ActionType action_type) {
+ switch (action_type) {
case arc::mojom::ActionType::VIEW:
return "view";
case arc::mojom::ActionType::SEND:
@@ -88,7 +88,7 @@ std::string ArcActionToString(arc::mojom::ActionType action) {
return "";
}
-arc::mojom::ActionType StringToArcAction(const std::string& str) {
+arc::mojom::ActionType StringToArcActionType(const std::string& str) {
if (str == "view")
return arc::mojom::ActionType::VIEW;
if (str == "send")
@@ -253,8 +253,8 @@ void OnArcIconEncoded(
for (const arc::mojom::IntentHandlerInfoPtr& handler : handlers) {
std::string name(handler->name);
Verb handler_verb = Verb::VERB_NONE;
- if (handler->action == arc::mojom::ActionType::SEND ||
- handler->action == arc::mojom::ActionType::SEND_MULTIPLE) {
+ if (handler->action_type == arc::mojom::ActionType::SEND ||
+ handler->action_type == arc::mojom::ActionType::SEND_MULTIPLE) {
handler_verb = Verb::VERB_SHARE_WITH;
}
const GURL& icon_url = (*icons)[arc::ActivityIconLoader::ActivityName(
@@ -262,9 +262,9 @@ void OnArcIconEncoded(
result_list->push_back(FullTaskDescriptor(
TaskDescriptor(
ActivityNameToAppId(handler->package_name, handler->activity_name),
- TASK_TYPE_ARC_APP, ArcActionToString(handler->action)),
+ TASK_TYPE_ARC_APP, ArcActionTypeToString(handler->action_type)),
name, handler_verb, icon_url, false /* is_default */,
- handler->action != arc::mojom::ActionType::VIEW /* is_generic */));
+ handler->action_type != arc::mojom::ActionType::VIEW /* is_generic */));
}
callback.Run(std::move(result_list));
}
@@ -341,11 +341,11 @@ bool ExecuteArcTask(Profile* profile,
kArcIntentHelperVersionWithFullActivityName)) {
arc_intent_helper->HandleUrlList(std::move(urls),
AppIdToActivityName(task.app_id),
- StringToArcAction(task.action_id));
+ StringToArcActionType(task.action_id));
} else {
arc_intent_helper->HandleUrlListDeprecated(
std::move(urls), AppIdToActivityName(task.app_id)->package_name,
- StringToArcAction(task.action_id));
+ StringToArcActionType(task.action_id));
}
return true;
}
« no previous file with comments | « no previous file | components/arc/common/intent_helper.mojom » ('j') | components/arc/common/intent_helper.mojom » ('J')

Powered by Google App Engine
This is Rietveld 408576698