arc: Add action to IntentHandlerInfo and rename enum fields.

components/arc/common/intent_helper.mojom

Index: components/arc/common/intent_helper.mojom
diff --git a/components/arc/common/intent_helper.mojom b/components/arc/common/intent_helper.mojom
index 2b60a9e2bd089d651259c53bf19fc5fc5a80d5a8..05bf9ca0a3df2217ee8927c475e108608208a253 100644
--- a/components/arc/common/intent_helper.mojom
+++ b/components/arc/common/intent_helper.mojom
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Next MinVersion: 11
+// Next MinVersion: 12
 
 module arc.mojom;
 
@@ -46,8 +46,9 @@ struct IntentHandlerInfo {
   string name;
   string package_name;
   string activity_name;  // A hint for retrieving the package's icon.
-  [MinVersion=4] ActionType action;
+  [MinVersion=4] ActionType action_type;
   [MinVersion=6] bool is_preferred;
+  [MinVersion=11] string? action;  // e.g. "android.intent.action.VIEW"

[dcheng, 2016/10/04 22:29:11]

How will this field be used?

[Daniel Erat, 2016/10/04 22:43:22]

i can document it in a comment if that'd be better, but i plan to remove
action_type and only use this field in order to support arbitrary intents
(http://crbug.com/647802). alternately, should i name the old field
"deprecated_action_type" instead?

[dcheng, 2016/10/04 22:49:41]

Usually, it's preferred to land this sort of change with something that's
actually using it (especially because for ipc reviews, it's preferred to use
something that's more strongly typed--like the current enum--over something less
loosely typed--like the newly added string field).

I assume that the ARC++ side is blocked on this CL landing though, so please
just CC an IPC reviewer on the followup CL that uses this in Chrome.

[Daniel Erat, 2016/10/04 22:57:35]

got it. yeah, chrome can't use this until the android side sets it, and i
believe that mojom changes are supposed to land in chrome first. i could update
this change so chrome also uses the string if it's present and falls back to the
enum otherwise, but i figured that switching chrome to only use the string in a
later change might make reviews easier.

 };
 
 // Describes an activity.
@@ -112,12 +113,12 @@ interface IntentHelperInstance {
   // Handles the list of URLs by sending a specified intent to the handler.
   [MinVersion=5] HandleUrlList@7(array<UrlWithMimeType> urls,
                                  ActivityName activity,
-                                 ActionType action);
+                                 ActionType action_type);
 
   // Deprecated. Use HandleUrlList.
   [MinVersion=4] HandleUrlListDeprecated@5(array<UrlWithMimeType> urls,
                                            string package_name,
-                                           ActionType action);
+                                           ActionType action_type);
 
   // Establishes full-duplex communication with the host.
   Init@0(IntentHelperHost host_ptr);