ServiceWorker: Mojofication of ServiceWorkerDispatcherHost

ServiceWorker: Mojofication of ServiceWorkerDispatcherHost

This patch is to mojofy ServiceWorkerDispatcherHost which is a browser-side
MessageFilter handling chromium IPC. Most of IPCs from the renderer to the
browser related to the service workers are going through this object, so I can
mojofy all of the IPCs using this way. In this patch, the ordering issue is
avoided by using AssociatedInterface bound to MessageChannel. As the first
touch, I mojofied ProviderCreated.

BUG=629701
Committed: https://crrev.com/804b3e4223615df89434bad6c33ed922393fd8c9
Cr-Commit-Position: refs/heads/master@{#425639}

[shimazu, 2016-10-07 04:13:45]

Patchset #2 (id:20001) has been deleted

[shimazu, 2016-10-07 04:22:55]

shimazu@chromium.org changed reviewers:
+ horo@chromium.org, mkwst@chromium.org

[shimazu, 2016-10-07 04:22:56]

ptal:)

[horo, 2016-10-07 07:39:29]

https://codereview.chromium.org/2396273002/diff/40001/content/browser/service...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/2396273002/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_dispatcher_host.cc:108:
base::Bind(&ServiceWorkerDispatcherHost::AddMojoBinding, GetWeakPtr()));
I think we don't need to use weak pointer.
base::Unretained()

https://codereview.chromium.org/2396273002/diff/40001/content/browser/service...
File content/browser/service_worker/service_worker_dispatcher_host.h (right):

https://codereview.chromium.org/2396273002/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_dispatcher_host.h:47: : public
mojom::ServiceWorkerDispatcherHost,
I think you can use BrowserAssociatedInterface.

https://codereview.chromium.org/2396273002/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_dispatcher_host.h:65: void
AddMojoBinding(mojo::ScopedInterfaceEndpointHandle handle);
Move to private.

[shimazu, 2016-10-14 08:15:02]

shimazu@chromium.org changed reviewers:
- mkwst@chromium.org

[shimazu, 2016-10-14 08:15:03]

updated!
ptal again

https://codereview.chromium.org/2396273002/diff/40001/content/browser/service...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/2396273002/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_dispatcher_host.cc:108:
base::Bind(&ServiceWorkerDispatcherHost::AddMojoBinding, GetWeakPtr()));
On 2016/10/07 07:39:29, horo wrote:
> I think we don't need to use weak pointer.
> base::Unretained()

Done.

https://codereview.chromium.org/2396273002/diff/40001/content/browser/service...
File content/browser/service_worker/service_worker_dispatcher_host.h (right):

https://codereview.chromium.org/2396273002/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_dispatcher_host.h:47: : public
mojom::ServiceWorkerDispatcherHost,
On 2016/10/07 07:39:29, horo wrote:
> I think you can use BrowserAssociatedInterface.

BrowserAssociatedInterface assume that the object inheriting
BrowserAssociatedInterface has 1:1 relation to the pointer.
(BrowserAssociatedInterface uses AssociatedBinding), so I implemented as this
(for using AssociatedBindingSet).

https://codereview.chromium.org/2396273002/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_dispatcher_host.h:65: void
AddMojoBinding(mojo::ScopedInterfaceEndpointHandle handle);
On 2016/10/07 07:39:29, horo wrote:
> Move to private.

Done.

[horo, 2016-10-15 01:01:36]

lgtm

[shimazu, 2016-10-17 01:44:19]

shimazu@chromium.org changed reviewers:
+ avi@chromium.org, mkwst@chromium.org

[shimazu, 2016-10-17 01:44:20]

mkwst: could you take a look at mojom, typemap and
content_browser_manifest.json?
avi: could you check the changes in BUILD.gn?

[Avi (use Gerrit), 2016-10-17 02:43:05]

On 2016/10/17 01:44:20, shimazu wrote:
> mkwst: could you take a look at mojom, typemap and
> content_browser_manifest.json?
> avi: could you check the changes in BUILD.gn?

build.gn lgtm

[Mike West, 2016-10-17 07:28:48]

mojo bits LGTM.

[shimazu, 2016-10-17 07:42:02]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2016-10-17 07:42:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 09:13:50]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-17 09:15:12]

Description was changed from

==========
ServiceWorker: Mojofication of ServiceWorkerDispatcherHost

This patch is to mojofy ServiceWorkerDispatcherHost which is a browser-side
MessageFilter handling chromium IPC. Most of IPCs from the renderer to the
browser related to the service workers are going through this object, so I can
mojofy all of the IPCs using this way. In this patch, the ordering issue is
avoided by using AssociatedInterface bound to MessageChannel. As the first
touch, I mojofied ProviderCreated.

BUG=629701
==========

to

==========
ServiceWorker: Mojofication of ServiceWorkerDispatcherHost

This patch is to mojofy ServiceWorkerDispatcherHost which is a browser-side
MessageFilter handling chromium IPC. Most of IPCs from the renderer to the
browser related to the service workers are going through this object, so I can
mojofy all of the IPCs using this way. In this patch, the ordering issue is
avoided by using AssociatedInterface bound to MessageChannel. As the first
touch, I mojofied ProviderCreated.

BUG=629701

Committed: https://crrev.com/804b3e4223615df89434bad6c33ed922393fd8c9
Cr-Commit-Position: refs/heads/master@{#425639}
==========

[commit-bot: I haz the power, 2016-10-17 09:15:13]

Patchset 3 (id:??) landed as
https://crrev.com/804b3e4223615df89434bad6c33ed922393fd8c9
Cr-Commit-Position: refs/heads/master@{#425639}