Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.h

Issue 2396273002: ServiceWorker: Mojofication of ServiceWorkerDispatcherHost (Closed)
Patch Set: Removed GetWeakPtr and moved a method to private Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_dispatcher_host.h
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.h b/content/browser/service_worker/service_worker_dispatcher_host.h
index bcd1dd8f721a5095ed15489af6fc605000cc6662..9aa1f97a5aae2845fadd3e3c679b7f507aaf053b 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.h
+++ b/content/browser/service_worker/service_worker_dispatcher_host.h
@@ -15,8 +15,10 @@
#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
#include "content/browser/service_worker/service_worker_registration_status.h"
+#include "content/common/service_worker/service_worker.mojom.h"
#include "content/common/service_worker/service_worker_types.h"
#include "content/public/browser/browser_message_filter.h"
+#include "mojo/public/cpp/bindings/associated_binding_set.h"
class GURL;
struct EmbeddedWorkerHostMsg_ReportConsoleMessage_Params;
@@ -41,7 +43,9 @@ struct ServiceWorkerRegistrationInfo;
struct ServiceWorkerRegistrationObjectInfo;
struct ServiceWorkerVersionAttributes;
-class CONTENT_EXPORT ServiceWorkerDispatcherHost : public BrowserMessageFilter {
+class CONTENT_EXPORT ServiceWorkerDispatcherHost
+ : public mojom::ServiceWorkerDispatcherHost,
+ public BrowserMessageFilter {
public:
ServiceWorkerDispatcherHost(
int render_process_id,
@@ -92,6 +96,16 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost : public BrowserMessageFilter {
using StatusCallback = base::Callback<void(ServiceWorkerStatusCode status)>;
+ // Called when mojom::ServiceWorkerDispatcherHostPtr is created on the
+ // renderer-side.
+ void AddMojoBinding(mojo::ScopedInterfaceEndpointHandle handle);
+
+ // mojom::ServiceWorkerDispatcherHost implementation
+ void OnProviderCreated(int provider_id,
+ int route_id,
+ ServiceWorkerProviderType provider_type,
+ bool is_parent_frame_secure) override;
+
// IPC Message handlers
void OnRegisterServiceWorker(int thread_id,
int request_id,
@@ -114,10 +128,6 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost : public BrowserMessageFilter {
void OnGetRegistrationForReady(int thread_id,
int request_id,
int provider_id);
- void OnProviderCreated(int provider_id,
- int route_id,
- ServiceWorkerProviderType provider_type,
- bool is_parent_frame_secure);
void OnProviderDestroyed(int provider_id);
void OnSetHostedVersionId(int provider_id,
int64_t version_id,
@@ -243,6 +253,10 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost : public BrowserMessageFilter {
bool channel_ready_; // True after BrowserMessageFilter::sender_ != NULL.
std::vector<std::unique_ptr<IPC::Message>> pending_messages_;
+ mojo::AssociatedBindingSet<mojom::ServiceWorkerDispatcherHost> bindings_;
+
+ base::WeakPtrFactory<ServiceWorkerDispatcherHost> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ServiceWorkerDispatcherHost);
};
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698