content/browser/service_worker/service_worker_provider_host.h - Issue 2396273002: ServiceWorker: Mojofication of ServiceWorkerDispatcherHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.h

Issue 2396273002: ServiceWorker: Mojofication of ServiceWorkerDispatcherHost (Closed)

Patch Set: Removed GetWeakPtr and moved a method to private Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_provider_host.h

diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h

index b29ea00d5f5c7db6ab9ade3ee0052d9718c49eb8..363360574b4a355797cc34fcab9429bfbe6d5094 100644

--- a/content/browser/service_worker/service_worker_provider_host.h

+++ b/content/browser/service_worker/service_worker_provider_host.h

@@ -262,7 +262,7 @@ class CONTENT_EXPORT ServiceWorkerProviderHost

void NotifyControllerLost();

private:

- friend class ServiceWorkerProviderHostTest;

+ friend class ServiceWorkerProviderHostTestP;

friend class ServiceWorkerWriteToCacheJobTest;

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerWriteToCacheJobTest, Update_SameScript);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerWriteToCacheJobTest,

@@ -285,7 +285,7 @@ class CONTENT_EXPORT ServiceWorkerProviderHost

UpdateForceBypassCache);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,

ServiceWorkerDataRequestAnnotation);

- FRIEND_TEST_ALL_PREFIXES(ServiceWorkerProviderHostTest, ContextSecurity);

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerProviderHostTestP, ContextSecurity);

struct OneShotGetReadyCallback {

GetRegistrationForReadyCallback callback;