[wasm] Remove three fields from wasm object

[wasm] Remove three fields from wasm object

Use information in the WasmCompiledModule instead.

R=titzer@chromium.org,mtrofin@chromium.org

Committed: https://crrev.com/8c7a413c9f975ea65fd87eda1e7eb4b83dc1769b
Cr-Commit-Position: refs/heads/master@{#40062}

[Clemens Hammacher, 2016-10-06 12:12:59]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 12:13:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 12:44:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 12:44:02]

Dry run: This issue passed the CQ dry run.

[Mircea Trofin, 2016-10-06 15:43:21]

lgtm, one nit

https://codereview.chromium.org/2396043002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2396043002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:1606: compiled_module->ptr_to_function_names(),
isolate);
wouldn't compiled_module->function_names() give you the same thing?

[titzer, 2016-10-06 15:55:09]

https://codereview.chromium.org/2396043002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2396043002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:992: return
static_cast<uint32_t>(compiled_module->ptr_to_import_data()->length());
That won't work in my latest patch; the number of imported functions is stored
directly now.

https://codereview.chromium.org/2396043002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:1649: SeqOneByteString* GetWasmBytes(JSObject* wasm) {
Please return a handle instead of a raw pointer here.

[Clemens Hammacher, 2016-10-06 18:42:55]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 18:43:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-10-06 18:46:50]

https://codereview.chromium.org/2396043002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2396043002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:992: return
static_cast<uint32_t>(compiled_module->ptr_to_import_data()->length());
On 2016/10/06 15:55:09, titzer wrote:
> That won't work in my latest patch; the number of imported functions is stored
> directly now.

Fixed as discussed.

https://codereview.chromium.org/2396043002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:1606: compiled_module->ptr_to_function_names(),
isolate);
On 2016/10/06 15:43:21, Mircea Trofin wrote:
> wouldn't compiled_module->function_names() give you the same thing?

Good catch, fixed.

https://codereview.chromium.org/2396043002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:1649: SeqOneByteString* GetWasmBytes(JSObject* wasm) {
On 2016/10/06 15:55:09, titzer wrote:
> Please return a handle instead of a raw pointer here.

Done.

[commit-bot: I haz the power, 2016-10-06 19:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 19:13:35]

Dry run: This issue passed the CQ dry run.

[Mircea Trofin, 2016-10-06 19:59:54]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2016-10-06 19:59:54]

The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2396043002/#ps20001
(title: "Address comments; handlify several places; rebase")

[commit-bot: I haz the power, 2016-10-06 19:59:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 20:02:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 20:03:07]

Description was changed from

==========
[wasm] Remove three fields from wasm object

Use information in the WasmCompiledModule instead.

R=titzer@chromium.org,mtrofin@chromium.org
==========

to

==========
[wasm] Remove three fields from wasm object

Use information in the WasmCompiledModule instead.

R=titzer@chromium.org,mtrofin@chromium.org

Committed: https://crrev.com/8c7a413c9f975ea65fd87eda1e7eb4b83dc1769b
Cr-Commit-Position: refs/heads/master@{#40062}
==========

[commit-bot: I haz the power, 2016-10-06 20:03:08]

Patchset 2 (id:??) landed as
https://crrev.com/8c7a413c9f975ea65fd87eda1e7eb4b83dc1769b
Cr-Commit-Position: refs/heads/master@{#40062}