Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2394663008:
[wasm] Extend wasm object validation to WasmCompiledModule (Closed)
|
Created:
4 years, 2 months ago by Clemens Hammacher Modified:
4 years, 2 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] Extend wasm object validation to WasmCompiledModule
I am removing three fields from the wasm object in a follow-up commit,
and using information in the compiled module instead. In order to not
weaken the verification, this commit adds appropriate checks on the
compiled module.
R=titzer@chromium.org,mtrofin@chromium.org
Committed: https://crrev.com/550364fb1256e8d46607e767654ae18cc4ef5015
Cr-Commit-Position: refs/heads/master@{#40061}
Patch Set 1 #Patch Set 2 : Add SLOW_DCHECK #Patch Set 3 : Fix early validation error #Patch Set 4 : Remove debug code #Messages
Total messages: 37 (31 generated)
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] Extend wasm object validation to WasmCompiledModule I am removing three fields from the wasm object in a follow-up commit, and using information in the compiled module instead. In order to not weaken the verification, this commit adds appropriate checks on the compiled module. R=titzer@chromium.org ========== to ========== [wasm] Extend wasm object validation to WasmCompiledModule I am removing three fields from the wasm object in a follow-up commit, and using information in the compiled module instead. In order to not weaken the verification, this commit adds appropriate checks on the compiled module. R=titzer@chromium.org,mtrofin@chromium.org ==========
clemensh@chromium.org changed reviewers: + mtrofin@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/14085)
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...) v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/15677)
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/14095) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
lgtm (assuming the green-ing of the red bot doesn't change the CL much)
lgtm
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/14118) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/10306) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by clemensh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org, mtrofin@chromium.org Link to the patchset: https://codereview.chromium.org/2394663008/#ps80001 (title: "Remove debug code")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wasm] Extend wasm object validation to WasmCompiledModule I am removing three fields from the wasm object in a follow-up commit, and using information in the compiled module instead. In order to not weaken the verification, this commit adds appropriate checks on the compiled module. R=titzer@chromium.org,mtrofin@chromium.org ========== to ========== [wasm] Extend wasm object validation to WasmCompiledModule I am removing three fields from the wasm object in a follow-up commit, and using information in the compiled module instead. In order to not weaken the verification, this commit adds appropriate checks on the compiled module. R=titzer@chromium.org,mtrofin@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] Extend wasm object validation to WasmCompiledModule I am removing three fields from the wasm object in a follow-up commit, and using information in the compiled module instead. In order to not weaken the verification, this commit adds appropriate checks on the compiled module. R=titzer@chromium.org,mtrofin@chromium.org ========== to ========== [wasm] Extend wasm object validation to WasmCompiledModule I am removing three fields from the wasm object in a follow-up commit, and using information in the compiled module instead. In order to not weaken the verification, this commit adds appropriate checks on the compiled module. R=titzer@chromium.org,mtrofin@chromium.org Committed: https://crrev.com/550364fb1256e8d46607e767654ae18cc4ef5015 Cr-Commit-Position: refs/heads/master@{#40061} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/550364fb1256e8d46607e767654ae18cc4ef5015 Cr-Commit-Position: refs/heads/master@{#40061} |
