Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: src/wasm/wasm-debug.cc

Issue 2396043002: [wasm] Remove three fields from wasm object (Closed)
Patch Set: Address comments; handlify several places; rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/module-decoder.cc ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-debug.cc
diff --git a/src/wasm/wasm-debug.cc b/src/wasm/wasm-debug.cc
index 42a8e5f2ab749305a122e5cbdf1234c2fffe5c7b..aaca8622b88b4b962d9963cd4fe437c738ffeb51 100644
--- a/src/wasm/wasm-debug.cc
+++ b/src/wasm/wasm-debug.cc
@@ -31,12 +31,11 @@ ByteArray *GetOrCreateFunctionOffsetTable(Handle<WasmDebugInfo> debug_info) {
FunctionOffsetsResult function_offsets;
{
- DisallowHeapAllocation no_gc;
Handle<JSObject> wasm_object(debug_info->wasm_object(), isolate);
uint32_t num_imported_functions =
- wasm::GetNumImportedFunctions(wasm_object);
- SeqOneByteString *wasm_bytes =
- wasm::GetWasmBytes(debug_info->wasm_object());
+ static_cast<uint32_t>(wasm::GetNumImportedFunctions(wasm_object));
+ Handle<SeqOneByteString> wasm_bytes = wasm::GetWasmBytes(wasm_object);
+ DisallowHeapAllocation no_gc;
const byte *bytes_start = wasm_bytes->GetChars();
const byte *bytes_end = bytes_start + wasm_bytes->length();
function_offsets = wasm::DecodeWasmFunctionOffsets(bytes_start, bytes_end,
@@ -72,8 +71,8 @@ std::pair<int, int> GetFunctionOffsetAndLength(Handle<WasmDebugInfo> debug_info,
Vector<const uint8_t> GetFunctionBytes(Handle<WasmDebugInfo> debug_info,
int func_index) {
- SeqOneByteString *module_bytes =
- wasm::GetWasmBytes(debug_info->wasm_object());
+ Handle<JSObject> wasm_object(debug_info->wasm_object());
+ Handle<SeqOneByteString> module_bytes = wasm::GetWasmBytes(wasm_object);
std::pair<int, int> offset_and_length =
GetFunctionOffsetAndLength(debug_info, func_index);
return Vector<const uint8_t>(
@@ -90,7 +89,7 @@ Handle<WasmDebugInfo> WasmDebugInfo::New(Handle<JSObject> wasm) {
factory->NewFixedArray(kWasmDebugInfoNumEntries, TENURED);
arr->set(kWasmDebugInfoWasmObj, *wasm);
int hash = 0;
- Handle<SeqOneByteString> wasm_bytes(GetWasmBytes(*wasm), isolate);
+ Handle<SeqOneByteString> wasm_bytes = GetWasmBytes(wasm);
{
DisallowHeapAllocation no_gc;
hash = StringHasher::HashSequentialString(
@@ -130,7 +129,8 @@ Script *WasmDebugInfo::GetFunctionScript(Handle<WasmDebugInfo> debug_info,
Object *scripts_obj = debug_info->get(kWasmDebugInfoFunctionScripts);
Handle<FixedArray> scripts;
if (scripts_obj->IsUndefined(isolate)) {
- int num_functions = wasm::GetNumberOfFunctions(debug_info->wasm_object());
+ Handle<JSObject> wasm_object(debug_info->wasm_object(), isolate);
+ int num_functions = wasm::GetNumberOfFunctions(wasm_object);
scripts = isolate->factory()->NewFixedArray(num_functions, TENURED);
debug_info->set(kWasmDebugInfoFunctionScripts, *scripts);
} else {
« no previous file with comments | « src/wasm/module-decoder.cc ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698