Issue 239543010: Revert "Move functions from handles.cc to where they belong."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239543010: Revert "Move functions from handles.cc to where they belong." (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Move functions from handles.cc to where they belong." This reverts r20802 . TBR=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20804

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+725 lines, -711 lines)			Patch
M	src/accessors.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/allocation-tracker.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/api.cc	View	16 chunks	+36 lines, -31 lines	0 comments	Download
M	src/bootstrapper.cc	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	src/builtins.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/compiler.cc	View	1 chunk	+9 lines, -12 lines	0 comments	Download
M	src/debug.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/frames.cc	View	5 chunks	+11 lines, -8 lines	0 comments	Download
M	src/gdb-jit.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/handles.h	View	2 chunks	+48 lines, -0 lines	0 comments	Download
M	src/handles.cc	View	3 chunks	+541 lines, -1 line	0 comments	Download
M	src/isolate.cc	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/json-stringifier.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/lithium-codegen.cc	View	2 chunks	+2 lines, -14 lines	0 comments	Download
M	src/liveedit.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/log.cc	View	3 chunks	+7 lines, -10 lines	0 comments	Download
M	src/messages.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	6 chunks	+1 line, -42 lines	0 comments	Download
M	src/objects.cc	View	5 chunks	+0 lines, -504 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/runtime.cc	View	11 chunks	+13 lines, -23 lines	0 comments	Download
M	test/cctest/test-compiler.cc	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-object-observe.cc	View	1 chunk	+9 lines, -8 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

6 years, 8 months ago (2014-04-16 12:36:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r20804 (presubmit successful).

Expand Messages | Collapse Messages