Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: src/bootstrapper.cc

Issue 239543010: Revert "Move functions from handles.cc to where they belong." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/builtins.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 854b42ac05098fbe8c8619f72c878120f5f21fa3..8f72623bd6408baf40c825ae6b6b6354b49d60f9 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2021,9 +2021,10 @@ static Handle<JSObject> ResolveBuiltinIdHolder(
static void InstallBuiltinFunctionId(Handle<JSObject> holder,
const char* function_name,
BuiltinFunctionId id) {
- Isolate* isolate = holder->GetIsolate();
+ Factory* factory = holder->GetIsolate()->factory();
+ Handle<String> name = factory->InternalizeUtf8String(function_name);
Handle<Object> function_object =
- Object::GetProperty(isolate, holder, function_name).ToHandleChecked();
+ Object::GetProperty(holder, name).ToHandleChecked();
Handle<JSFunction> function = Handle<JSFunction>::cast(function_object);
function->shared()->set_function_data(Smi::FromInt(id));
}
@@ -2130,8 +2131,7 @@ bool Genesis::InstallSpecialObjects(Handle<Context> native_context) {
false);
}
- Handle<Object> Error = Object::GetProperty(
- isolate, global, "Error").ToHandleChecked();
+ Handle<Object> Error = GetProperty(global, "Error").ToHandleChecked();
if (Error->IsJSObject()) {
Handle<String> name = factory->InternalizeOneByteString(
STATIC_ASCII_VECTOR("stackTraceLimit"));
@@ -2312,8 +2312,10 @@ bool Genesis::InstallJSBuiltins(Handle<JSBuiltinsObject> builtins) {
HandleScope scope(isolate());
for (int i = 0; i < Builtins::NumberOfJavaScriptBuiltins(); i++) {
Builtins::JavaScript id = static_cast<Builtins::JavaScript>(i);
- Handle<Object> function_object = Object::GetProperty(
- isolate(), builtins, Builtins::GetName(id)).ToHandleChecked();
+ Handle<String> name =
+ factory()->InternalizeUtf8String(Builtins::GetName(id));
+ Handle<Object> function_object =
+ Object::GetProperty(builtins, name).ToHandleChecked();
Handle<JSFunction> function = Handle<JSFunction>::cast(function_object);
builtins->set_javascript_builtin(id, *function);
if (!Compiler::EnsureCompiled(function, CLEAR_EXCEPTION)) {
« no previous file with comments | « src/api.cc ('k') | src/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698