Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: src/log.cc

Issue 239543010: Revert "Move functions from handles.cc to where they belong." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/liveedit.cc ('k') | src/messages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index e326f181d7df9f27bad4906f3c6e1ae992f058ca..896350e82b2de6f428f78aa16849cdc2d808358c 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -1150,8 +1150,7 @@ void Logger::LogRegExpSource(Handle<JSRegExp> regexp) {
// (re.global?"g":"") + (re.ignorecase?"i":"") + (re.multiline?"m":"")
Log::MessageBuilder msg(log_);
- Handle<Object> source = Object::GetProperty(
- isolate_, regexp, "source").ToHandleChecked();
+ Handle<Object> source = GetProperty(regexp, "source").ToHandleChecked();
if (!source->IsString()) {
msg.Append("no source");
return;
@@ -1169,20 +1168,18 @@ void Logger::LogRegExpSource(Handle<JSRegExp> regexp) {
msg.Append('/');
// global flag
- Handle<Object> global = Object::GetProperty(
- isolate_, regexp, "global").ToHandleChecked();
+ Handle<Object> global = GetProperty(regexp, "global").ToHandleChecked();
if (global->IsTrue()) {
msg.Append('g');
}
// ignorecase flag
- Handle<Object> ignorecase = Object::GetProperty(
- isolate_, regexp, "ignoreCase").ToHandleChecked();
+ Handle<Object> ignorecase =
+ GetProperty(regexp, "ignoreCase").ToHandleChecked();
if (ignorecase->IsTrue()) {
msg.Append('i');
}
// multiline flag
- Handle<Object> multiline = Object::GetProperty(
- isolate_, regexp, "multiline").ToHandleChecked();
+ Handle<Object> multiline = GetProperty(regexp, "multiline").ToHandleChecked();
if (multiline->IsTrue()) {
msg.Append('m');
}
@@ -1908,9 +1905,9 @@ void Logger::LogExistingFunction(Handle<SharedFunctionInfo> shared,
Handle<String> func_name(shared->DebugName());
if (shared->script()->IsScript()) {
Handle<Script> script(Script::cast(shared->script()));
- int line_num = Script::GetLineNumber(script, shared->start_position()) + 1;
+ int line_num = GetScriptLineNumber(script, shared->start_position()) + 1;
int column_num =
- Script::GetColumnNumber(script, shared->start_position()) + 1;
+ GetScriptColumnNumber(script, shared->start_position()) + 1;
if (script->name()->IsString()) {
Handle<String> script_name(String::cast(script->name()));
if (line_num > 0) {
« no previous file with comments | « src/liveedit.cc ('k') | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698