[modules] Give Module an internal [hash] field

[modules] Give Module an internal [hash] field

This allows us to stop using a Symbol, set as the name of the Module's
SharedFunctionInfo, as our storage for a hash.

As part of this, centralize the code for generating a random, non-zero
hash code in one place (there were previously two copies of this code,
and I needed to call it from a third file).

BUG=v8:5483
TBR=jochen@chromium.org

Committed: https://crrev.com/2d4871c143d916ce3c5f047d8722b0f854089652
Cr-Commit-Position: refs/heads/master@{#40102}

[adamk, 2016-10-06 23:05:03]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 23:05:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-10-06 23:08:00]

adamk@chromium.org changed reviewers:
+ neis@chromium.org

[adamk, 2016-10-06 23:08:01]

Hi Georg,

Here's a fix for the hash issue.

I couldn't figure out a way to get the test to "fail" in the right way without
this patch. That is, if I marked it as a modules-fail- test, the testrunner
didn't have a problem. Same thing if I actually caught the exception in the test
itself. Let me know if you have some idea for how to test this.

[commit-bot: I haz the power, 2016-10-06 23:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 23:36:53]

Dry run: This issue passed the CQ dry run.

[neis, 2016-10-07 09:21:41]

lgtm

On 2016/10/06 23:08:01, adamk wrote:
> I couldn't figure out a way to get the test to "fail" in the right way without
> this patch. That is, if I marked it as a modules-fail- test, the testrunner
> didn't have a problem. Same thing if I actually caught the exception in the
test
> itself. Let me know if you have some idea for how to test this.

Sorry, I'm lost. Which test are you referring to?

[neis, 2016-10-07 09:21:50]

https://codereview.chromium.org/2395233003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2395233003/diff/1/src/objects.h#newcode7906
src/objects.h:7906: // Hash code for this object (a random non-zero Smi).
s/code // to avoid confusion in the following comments

[adamk, 2016-10-07 17:36:09]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-10-07 17:36:09]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2395233003/#ps20001
(title: "Fix comment")

[commit-bot: I haz the power, 2016-10-07 17:36:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-10-07 17:37:35]

adamk@chromium.org changed reviewers:
+ jochen@chromium.org

[adamk, 2016-10-07 17:37:35]

+jochen for heap/OWNERS

The test I was referring to is the one in the attached bug.

https://codereview.chromium.org/2395233003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2395233003/diff/1/src/objects.h#newcode7906
src/objects.h:7906: // Hash code for this object (a random non-zero Smi).
On 2016/10/07 09:21:50, neis wrote:
> s/code // to avoid confusion in the following comments

Done.

[commit-bot: I haz the power, 2016-10-07 17:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 17:41:46]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25952)

[adamk, 2016-10-07 19:04:57]

Description was changed from

==========
[modules] Give Module an internal [hash] field

This allows us to stop using a Symbol, set as the name of the Module's
SharedFunctionInfo, as our storage for a hash.

As part of this, centralize the code for generating a random, non-zero
hash code in one place (there were previously two copies of this code,
and I needed to call it from a third file).

BUG=v8:5483
==========

to

==========
[modules] Give Module an internal [hash] field

This allows us to stop using a Symbol, set as the name of the Module's
SharedFunctionInfo, as our storage for a hash.

As part of this, centralize the code for generating a random, non-zero
hash code in one place (there were previously two copies of this code,
and I needed to call it from a third file).

BUG=v8:5483
TBR=jochen@chromium.org
==========

[adamk, 2016-10-07 19:05:16]

Marking jochen as TBR, since this really doesn't have anything to do with "heap"
per se.

[adamk, 2016-10-07 19:05:22]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-10-07 19:05:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-10-07 19:07:29]

The CQ bit was unchecked by adamk@chromium.org

[adamk, 2016-10-07 21:08:56]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-10-07 21:08:56]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2395233003/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-10-07 21:09:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 21:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 21:54:04]

Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/14205)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[adamk, 2016-10-07 22:01:10]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-10-07 22:01:11]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2395233003/#ps60001
(title: "Fix merge")

[commit-bot: I haz the power, 2016-10-07 22:01:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 22:29:08]

Description was changed from

==========
[modules] Give Module an internal [hash] field

This allows us to stop using a Symbol, set as the name of the Module's
SharedFunctionInfo, as our storage for a hash.

As part of this, centralize the code for generating a random, non-zero
hash code in one place (there were previously two copies of this code,
and I needed to call it from a third file).

BUG=v8:5483
TBR=jochen@chromium.org
==========

to

==========
[modules] Give Module an internal [hash] field

This allows us to stop using a Symbol, set as the name of the Module's
SharedFunctionInfo, as our storage for a hash.

As part of this, centralize the code for generating a random, non-zero
hash code in one place (there were previously two copies of this code,
and I needed to call it from a third file).

BUG=v8:5483
TBR=jochen@chromium.org
==========

[commit-bot: I haz the power, 2016-10-07 22:29:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-07 22:29:24]

Description was changed from

==========
[modules] Give Module an internal [hash] field

This allows us to stop using a Symbol, set as the name of the Module's
SharedFunctionInfo, as our storage for a hash.

As part of this, centralize the code for generating a random, non-zero
hash code in one place (there were previously two copies of this code,
and I needed to call it from a third file).

BUG=v8:5483
TBR=jochen@chromium.org
==========

to

==========
[modules] Give Module an internal [hash] field

This allows us to stop using a Symbol, set as the name of the Module's
SharedFunctionInfo, as our storage for a hash.

As part of this, centralize the code for generating a random, non-zero
hash code in one place (there were previously two copies of this code,
and I needed to call it from a third file).

BUG=v8:5483
TBR=jochen@chromium.org

Committed: https://crrev.com/2d4871c143d916ce3c5f047d8722b0f854089652
Cr-Commit-Position: refs/heads/master@{#40102}
==========

[commit-bot: I haz the power, 2016-10-07 22:29:25]

Patchset 4 (id:??) landed as
https://crrev.com/2d4871c143d916ce3c5f047d8722b0f854089652
Cr-Commit-Position: refs/heads/master@{#40102}