[modules] Give Module an internal [hash] field

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 #include <memory>
 
@@ skipping 7885 matching lines @@
   // [[Evaluated]]: Whether this module has been evaluated. Modules
   // are only evaluated a single time.
   DECL_BOOLEAN_ACCESSORS(evaluated)
 
   // Storage for [[Evaluated]]
   DECL_INT_ACCESSORS(flags)
 
   // Embedder-specified data
   DECL_ACCESSORS(embedder_data, Object)
 
+  // Hash code for this object (a random non-zero Smi).

[neis, 2016/10/07 09:21:50]

s/code // to avoid confusion in the following comments

[adamk, 2016/10/07 17:37:35]

Done.

+  DECL_INT_ACCESSORS(hash)
+
   // Get the SharedFunctionInfo associated with the code.
   inline SharedFunctionInfo* shared() const;
 
   // Get the ModuleInfo associated with the code.
   inline ModuleInfo* info() const;
 
-  // Compute a hash for this object.
-  inline uint32_t Hash() const;
-
   // Implementation of spec operation ModuleDeclarationInstantiation.
   // Returns false if an exception occurred during instantiation, true
   // otherwise.
   static MUST_USE_RESULT bool Instantiate(Handle<Module> module,
                                           v8::Local<v8::Context> context,
                                           v8::Module::ResolveCallback callback,
                                           v8::Local<v8::Value> callback_data);
 
   // Implementation of spec operation ModuleEvaluation.
   static MUST_USE_RESULT MaybeHandle<Object> Evaluate(Handle<Module> module);
 
   static Handle<Object> LoadExport(Handle<Module> module, Handle<String> name);
   static void StoreExport(Handle<Module> module, Handle<String> name,
                           Handle<Object> value);
 
   static Handle<Object> LoadImport(Handle<Module> module, Handle<String> name,
                                    int module_request);
 
   static const int kCodeOffset = HeapObject::kHeaderSize;
   static const int kExportsOffset = kCodeOffset + kPointerSize;
   static const int kRequestedModulesOffset = kExportsOffset + kPointerSize;
   static const int kFlagsOffset = kRequestedModulesOffset + kPointerSize;
   static const int kEmbedderDataOffset = kFlagsOffset + kPointerSize;
-  static const int kSize = kEmbedderDataOffset + kPointerSize;
+  static const int kHashOffset = kEmbedderDataOffset + kPointerSize;
+  static const int kSize = kHashOffset + kPointerSize;
 
  private:
   enum { kEvaluatedBit };
 
   static void CreateExport(Handle<Module> module, Handle<FixedArray> names);
   static void CreateIndirectExport(Handle<Module> module, Handle<String> name,
                                    Handle<ModuleInfoEntry> entry);
 
   // The [must_resolve] argument indicates whether or not an exception should be
   // thrown in case the module does not provide an export named [name]
@@ skipping 3456 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_