Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/objects-debug.cc

Issue 2395233003: [modules] Give Module an internal [hash] field (Closed)
Patch Set: Fix merge Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 2986982c0f036774b693966d8add47066b8bc3cf..75320677c557e18bce4085eef8e3793614623ce0 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -936,7 +936,7 @@ void Module::ModuleVerify() {
requested_modules()->ObjectVerify();
VerifySmiField(kFlagsOffset);
embedder_data()->ObjectVerify();
- CHECK(shared()->name()->IsSymbol());
+ VerifySmiField(kHashOffset);
CHECK(module_namespace()->IsUndefined(isolate) ||
module_namespace()->IsJSModuleNamespace());
// TODO(neis): Check more.
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698