Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2394883002: Enforce comment formatting in modules/ (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, timvolodine, blink-reviews, Srirama, Ken Russell (switch to Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enforce comment formatting in modules/ Also rewrap a few last comments that landed in the last day. Like https://codereview.chromium.org/2391793003/ but for modules. BUG=563793 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/723d46c6083ad4f732675a138f577f51be536a34 Cr-Commit-Position: refs/heads/master@{#423206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
A + third_party/WebKit/Source/modules/.clang-format View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Nico
dcheng: review haraken: owners kbr: fyi (webgl change)
4 years, 2 months ago (2016-10-05 15:17:39 UTC) #5
dcheng
lgtm
4 years, 2 months ago (2016-10-05 15:45:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394883002/1
4 years, 2 months ago (2016-10-05 16:50:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394883002/1
4 years, 2 months ago (2016-10-05 17:32:57 UTC) #14
Ken Russell (switch to Gerrit)
lgtm
4 years, 2 months ago (2016-10-05 17:37:43 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 17:38:52 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/723d46c6083ad4f732675a138f577f51be536a34 Cr-Commit-Position: refs/heads/master@{#423206}
4 years, 2 months ago (2016-10-05 17:40:43 UTC) #20
haraken
4 years, 2 months ago (2016-10-05 23:11:35 UTC) #21
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698