Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2394353003: Apply RuleSet changes for active stylesheet changes. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply RuleSet changes for active stylesheet changes. Introduce an applyRuleSetChanges method which will take the old and new ActiveStyleSheetVector use the existing comparison method and apply the RuleSet diff to invalidate style for the document. The normal mode for style rules is to schedule RuleSet invalidations which will decide what to recalculate based on the invalidation sets. Universal selectors, the presence of Shadow DOM v0 combinators, or @font-face rules for the document scope, will cause a subtree recalc for the TreeScope. @keyframes rules utilizes the existing functionality for invalidating style in the TreeScope and the host TreeScope for running and unresolved animations. This CL introduces appendActiveStyleSheets which will eventually replace the combination of the lazy appending of sheets in StyleResolver and appending pending sheets into the ScopedStyleResolver through appendCSSStyleSheet. This CL is split out of https://codereview.chromium.org/1913833002 and re-worked a bit. The functionality is not yet in use. R=meade@chromium.org BUG=567021 Committed: https://crrev.com/f8da12ea4e2bb01417c8a86a4e2b21f54b5d93fd Cr-Commit-Position: refs/heads/master@{#423810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/ActiveStyleSheets.h View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheets.cpp View 2 chunks +94 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp View 2 chunks +134 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 3 chunks +19 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 2 months ago (2016-10-06 22:15:48 UTC) #3
meade_UTC10
lgtm
4 years, 2 months ago (2016-10-07 03:01:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394353003/1
4 years, 2 months ago (2016-10-07 06:41:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 06:46:13 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 06:47:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8da12ea4e2bb01417c8a86a4e2b21f54b5d93fd
Cr-Commit-Position: refs/heads/master@{#423810}

Powered by Google App Engine
This is Rietveld 408576698