Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1913833002: Current work-in-progress crbug.com/567021 (Closed)

Created:
4 years, 8 months ago by rune
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, devtools-reviews_chromium.org, Yoav Weiss, blink-reviews-html_chromium.org, gavinp+prerender_chromium.org, blink-reviews-style_chromium.org, pfeldman+blink_chromium.org, webcomponents-bugzilla_chromium.org, tfarina, blink-reviews-css, sof, eae+blinkwatch, caseq+blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Current work-in-progress crbug.com/567021 *** NOT FOR LANDING ***

Patch Set 1 #

Patch Set 2 : Current state #

Patch Set 3 : Rebased++ #

Patch Set 4 : More work #

Patch Set 5 : Current changes #

Patch Set 6 : #

Patch Set 7 : More assert fixes #

Patch Set 8 : #

Patch Set 9 : Rebased #

Patch Set 10 : Should fix interactive_ui_tests #

Patch Set 11 : Fixed inspector tests #

Patch Set 12 : Fixed alternate style recalc test and expectations. #

Patch Set 13 : Rebased #

Patch Set 14 : Missing CORE_EXPORT. #

Patch Set 15 : Missing include #

Patch Set 16 : Fix for print media #

Patch Set 17 : viewport #

Patch Set 18 : Keyframes optimization #

Patch Set 19 : Rebased #

Patch Set 20 : Rebased #

Patch Set 21 : WIP #

Patch Set 22 : Fixes #

Patch Set 23 : More fixes #

Patch Set 24 : Rebased #

Patch Set 25 : Removed submitted patches #

Patch Set 26 : Removed another submitted CL #

Patch Set 27 : Rebased #

Patch Set 28 : Fixed html import issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -805 lines) Patch
M third_party/WebKit/LayoutTests/animations/add-keyframes-in-shadow-recalc.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/html/imports/import-add-child-to-change-order-of-dup-css.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 2 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 4 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 5 chunks +1 line, -59 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 3 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +21 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollector.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollector.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +8 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 8 chunks +9 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 27 chunks +50 lines, -144 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleSheetCollection.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 4 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleSheetCollection.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +4 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 3 chunks +5 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +19 lines, -127 lines 0 comments Download
D third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollectionTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -152 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLStyleElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +6 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/imports/LinkImport.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 33 (23 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913833002/240001
4 years, 6 months ago (2016-06-06 13:28:33 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/105490)
4 years, 6 months ago (2016-06-06 13:57:22 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913833002/260001
4 years, 6 months ago (2016-06-06 14:27:01 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/77118)
4 years, 6 months ago (2016-06-06 14:38:38 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913833002/280001
4 years, 6 months ago (2016-06-06 19:25:42 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/224053)
4 years, 6 months ago (2016-06-06 20:19:24 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913833002/230071
4 years, 6 months ago (2016-06-07 12:55:15 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 14:40:21 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1913833002/350001
4 years, 5 months ago (2016-07-01 11:13:43 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 12:50:32 UTC) #20 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698